add support for optional deps in otp24

erlware / relx

Sane, simple release creation for Erlang

http://erlware.github.io/relx

Apache License 2.0

697 stars 232 forks source link

add support for optional deps in otp24 #885

Closed evanmcc closed 2 years ago

evanmcc commented 3 years ago

rebar3 currently throws an error when building releases with optional applications, which were added in OTP 24. see: https://github.com/erlang/rebar3/issues/2473 for more context. it turns out that relx assumes that all deps it knows about are required, so this PR threads the optional application information through rebar3 and into relx, then does the right thing with it.

tsloughter commented 3 years ago

Is there a need for backwards compat? Only rebar3 uses this library and it is built with a specific locked version.

ferd commented 3 years ago

The need isn't super hard, but I guess it technically requires a bump to 5.0.0 then.

tsloughter commented 3 years ago

I don't think relx has been following semver. Except for that 4.0 bump I guess.

But yea, if keeping backwards compat isn't much trouble we may as well.

tsloughter commented 2 years ago

Replaced by #898