Closed shino closed 2 years ago
Oops, CI on windows failed... can't debug it...
There is another PR to save the situation, https://github.com/erlang/otp/pull/5852 . h/t @garazdawi
The original issue https://github.com/erlang/otp/issues/5826 has been solved by Erlang/OTP side https://github.com/erlang/otp/pull/5852 . h/t garazdawi Close this.
At OTP 25.0-rc2, the release with setting
{include_erts, false}
results in error.cf. Release fails to start when rebar3's include_erts=false is used, 25.0-rc2 · Issue #5826 · erlang/otp https://github.com/erlang/otp/issues/5826
The current relx's release sets
ROOTDIR
toRELEASE_ROOT_DIR
and exports it, andcode:root_dir()
is set to there. On the other hand, https://github.com/erlang/otp/commit/a32f6d210a58ba1e56f54f07c91106efed2c0777 assumes there existsROOTDIR/erts-<VSN>/bin/inet_gethost
, which is spec conformant acording to the discussion at https://github.com/erlang/otp/issues/5826 .This PR's changes are as follows:
ROOTDIR
RELEASE_DIR
boot variable as it is used in windows caseBecause I don't have windows box, this PR might be incomplete. Anyway, I hope this can be the base for discussion.