search

erlware / relx

Sane, simple release creation for Erlang
http://erlware.github.io/relx
Apache License 2.0
696 stars 233 forks source link

Force use of nodetool if proto_dist set #923

Closed GlenWalker closed 2 years ago

GlenWalker commented 2 years ago

When using a custom proto_dist (in our case a custom TLS wrapper) for distribution erl_call doesn't work as it doesn't support proto_dist, and so the extended_bin script doesn't work correctly.

Forcing use of nodetool instead of erl_call in this situation fixes the issue.

If necessary we could also check for specific values of proto_dist to avoid forcing use of nodetool when not strictly required (e.g. still use erl_call if proto_dist is inet_tcp)

GlenWalker commented 2 years ago

My local branch was named "nodetool_proto_dist", and I did attempt to follow the instructions in CONTRIBUTING.md, but have managed to fail that. Let me know if you want be to make a fresh PR from the proper branch.

GlenWalker commented 2 years ago

Replaced with fresh PR from nodetool_proto_dist branch