search

erlyaws / yaws

Yaws webserver
https://erlyaws.github.io
BSD 3-Clause "New" or "Revised" License
1.28k stars 267 forks source link

yaws no longer works as rebar dependency #178

Closed marcsugiyama closed 10 years ago

marcsugiyama commented 10 years ago

rebar looks for .app and .app.src files. The yaws.app.src is now yaws.app.src.in, so rebar fails with:

DEBUG: is_app_available, looking for App yaws with Path "/Users/sugiyama/work/git/clones/flowforwarding/loom/tapestry/deps/yaws" WARN: Expected /Users/sugiyama/work/git/clones/flowforwarding/loom/tapestry/deps/yaws to be an app dir (containing ebin/*.app), but no .app found. ERROR: Dependency dir /Users/sugiyama/work/git/clones/flowforwarding/loom/tapestry/deps/yaws failed application validation with reason: {missing_app_file,"/Users/sugiyama/work/git/clones/flowforwarding/loom/tapestry/deps/yaws"}.

Works with yaws-1.98.

vinoski commented 10 years ago

Thanks for the report. I'll work on a fix.

vinoski commented 10 years ago

Unfortunately rebar looks for a .app or .app.src file before executing the rebar.config.script file. which IMO is wrong but that's the way it is. Due to that, to fix this I'll have to undo or rework a recent change I made for allowing control over the app dependencies in the .app file.

vinoski commented 10 years ago

I believe this is now fixed on master. Please give it a try if you can @marcsugiyama and let me know.

vinoski commented 10 years ago

My testing shows this is fixed, so I'm closing it.

marcsugiyama commented 10 years ago

I just had a chance to test it now. It looks like it's working. Thanks!

NateBrady23 commented 8 years ago

Hi @vinoski, I was wondering what release this fix was put into and if it still applies. It seems as though I'm having exactly the same problems on all versions I've tried.

vinoski commented 8 years ago

@nbrady-techempower: the fix is in Yaws 1.99 and newer. You might want to check the version of rebar you're using, as different versions have had issues with this sort of thing over the years. I believe 2.6.1 is the latest released version of rebar.

NateBrady23 commented 8 years ago

@vinoski Ah, always when I'm looking in the wrong place. Was part of the enterprise version of erlang I was using. Thanks so much!