search

erlyaws / yaws

Yaws webserver
https://erlyaws.github.io
BSD 3-Clause "New" or "Revised" License
1.28k stars 267 forks source link

Remove version attribute from yaws_api:set_cookie/3 #349

Closed leoliu closed 5 years ago

leoliu commented 5 years ago

The Version cookie attribute no longer appears in RFC 6265.

Fixes #330.

leoliu commented 5 years ago

The CI failure seems irrelevant to the change:

(ct@travis-job-klacke-yaws-457611607)1> {removed_failing_handler,error_logger}
{"Kernel pid terminated",application_controller,"{application_start_failure,yaws,{{shutdown,{failed_to_start_child,yaws_server,{badbind,[{yaws_server,start_group,2,[{file,\"yaws_server.erl\"},{line,261}]},{lists,filtermap,2,[{file,\"lists.erl\"},{line,1317}]},{yaws_server,init2,5,[{file,\"yaws_server.erl\"},{line,245}]},{gen_server,init_it,2,[{file,\"gen_server.erl\"},{line,374}]},{gen_server,init_it,6,[{file,\"gen_server.erl\"},{line,342}]},{proc_lib,init_p_do_apply,3,[{file,\"proc_lib.erl\"},{line,249}]}]}}},{yaws_app,start,[normal,[]]}}}"}
============================================================================
make[2]: *** [common_test] Error 1
make[2]: Leaving directory `/home/travis/build/klacke/yaws/testsuite'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/travis/build/klacke/yaws/testsuite'
make: *** [check-recursive] Error 1
The command "make check -j4 V=1" exited with 2.
vinoski commented 5 years ago

I reran the one failing platform under CI and it passed, so this is good to go.