Incorrect handling of unicode chars in request path

erlyaws / yaws

Yaws webserver

https://erlyaws.github.io

BSD 3-Clause "New" or "Revised" License

1.29k stars 267 forks source link

Incorrect handling of unicode chars in request path #378

Closed leoliu closed 5 years ago

leoliu commented 5 years ago

I just discovered a bug probably from fixing https://github.com/klacke/yaws/issues/329. 404 is returned for any request path that has unicode chars in it. For example place a file 你好.txt in a directory that is served by yaws and try to view it.

The requested URL /%E4%BD%A0%E5%A5%BD.txt was not found on this server.

leoliu commented 5 years ago

@vinoski This bug is happening again with Yaws 866f3634224358c21bd59b403a6e1c0c936b76dd

vinoski commented 5 years ago

That's unfortunate; reopening this issue.

vinoski commented 5 years ago

I pushed b703951, which I believe re-fixes this.

leoliu commented 5 years ago

@vinoski I can confirm the fix. Thanks a lot.

vinoski commented 5 years ago

Thank you!