erlyaws / yaws

Yaws webserver
https://erlyaws.github.io
BSD 3-Clause "New" or "Revised" License
1.28k stars 267 forks source link

Rebar3 master #480

Closed Juliusan closed 4 months ago

Juliusan commented 5 months ago

I use Yaws on Erlang OTP26 and I also build my projects using rebar3. I know, there is a rebar compatibility branch rebar3-support, however, it is too old and doesn't work with OTP26. Moreover, master branch of Yaws is updated to OTP26, but it has problems building all C dependencies using rebar3. I've merged these two branches. Please either use this PR to include rebar3 compatibility in master branch or make a rebase on master of rebar3-support.

vinoski commented 5 months ago

Thanks, I'll take a look.

vinoski commented 5 months ago

@Juliusan, question: I assume that rebar3 eunit or rebar3 ct still don't work with your changes?

Juliusan commented 5 months ago

@Juliusan, question: I assume that rebar3 eunit or rebar3 ct still don't work with your changes?

"My changes" is saying it too loud :-D I just merged two existing branches and fixed a few merge conflicts, which occurred in make file and documentation.

To answer your question: I use yaws as a dependency and haven't tried running tests on it. But yes, you are right. Both eunit and ct fail with 'export_all flag enabled - all functions will be exported' in different files.

Shouldn't be hard to fix that, I suppose. And it is supposed to be a warning. I'll have a look.

vinoski commented 5 months ago

No need to fix the export_all issue, I already have it fixed locally. But there are more problems after fixing that.

I was asking about the rebar3 commands just so I would know what to expect when reviewing your PR. Thanks for the clarification!

vinoski commented 4 months ago

I'm still working on this.

vinoski commented 4 months ago

I manually rebased the whole branch and updated it to fix a few things, then merged it to master as a single commit. Thanks for pushing this forward!

Juliusan commented 4 months ago

Thank you for doing this :-)