search

ermalkaleci / CarbonKit

CarbonKit - iOS Components (Obj-C & Swift)
MIT License
682 stars 164 forks source link

iOS 13 Crash and just find issues.Please repair it as soon as possible. #241

Closed gaojlieMan closed 4 years ago

gaojlieMan commented 4 years ago

iOS 13 Crash and just find issues.Please repair it as soon as possible.

prakashRavi1990 commented 4 years ago

Hi,

Please find the crash details here.

* Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '<#Mycontroller#: 0x7fb2904a7e70> returned nil from -traitCollection, which is not allowed.'**

This is happening when I am initialising the controller,

let carbonTabSwipeNavigation = CarbonTabSwipeNavigation(items: serviceSegmentTypes, delegate: self)

@gaojlieMan : You got the same? or Different?

gaojlieMan commented 4 years ago

the same with you.How Should I solve the problem？

------------------ 原始邮件 ------------------ 发件人: "prakashRavi1990"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午2:33 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

Hi,

Please find the crash details here.

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '<#Mycontroller#: 0x7fb2904a7e70> returned nil from -traitCollection, which is not allowed.'

This is happening when I am initialising the controller,

let carbonTabSwipeNavigation = CarbonTabSwipeNavigation(items: serviceSegmentTypes, delegate: self)

@gaojlieMan : You got the same? or Different?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ermalkaleci commented 4 years ago

@prakashRavi1990 @gaojlieMan checkout example project. if it works ok then your problem is somewhere else

gaojlieMan commented 4 years ago

019-09-24 15:22:02.889176+0800 CarbonKitExample[5993:3225422] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '<ViewControllerOne: 0x10532b2b0> returned nil from -traitCollection, which is not allowed.' OC demo crash is the same with my project crash,How can solve it?

------------------ 原始邮件 ------------------ 发件人: "Ermal Kaleci"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午3:12 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

@prakashRavi1990 @gaojlieMan checkout example project. if it works ok then your problem is somewhere else

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

prakashRavi1990 commented 4 years ago

The thing is when we try to access the UIElement in the initial loading view controller the following issue occurs

Example: i am having search bar in the FirstViewController. While try to access the search bar like

searchBar.searchBarStyle = .minimal

I am getting ** Assertion failure in UITraitCollection _Nonnull _UIGetCurrentFallbackTraitCollection(void)(), /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKitCore_Sim/UIKit-3899.13.13/_UIFallbackEnvironment.m:91

The sad part is in Xcode 11 only I am facing this issue. All the other view controllers are working fine. The one with CarbonKit is not working.

@ermalkaleci @gaojlieMan please let me know if you find any solution to this.

gaojlieMan commented 4 years ago

How can I slove it ?Can you help me

------------------ 原始邮件 ------------------ 发件人: "prakashRavi1990"; 发送时间: 2019年9月24日(星期二) 下午3:45 收件人: "ermalkaleci/CarbonKit"; 抄送: "gaojlieMan"401633128@qq.com;"Mention"; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

The thing is when we try to access the UIElement in the initial loading view controller the following issue occurs

Example: i am having search bar in the FirstViewController. While try to access the search bar like

searchBar.searchBarStyle = .minimal

I am getting ** Assertion failure in UITraitCollection _Nonnull _UIGetCurrentFallbackTraitCollection(void)(), /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKitCore_Sim/UIKit-3899.13.13/_UIFallbackEnvironment.m:91

The sad part is in Xcode 11 only I am facing this issue. All the other view controllers are working fine. The one with CarbonKit is not working.

@ermalkaleci @gaojlieMan please let me know if you find any solution to this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gaojlieMan commented 4 years ago

How can run your demo that can run no problem

------------------ 原始邮件 ------------------ 发件人: "prakashRavi1990"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午3:45 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

The thing is when we try to access the UIElement in the initial loading view controller the following issue occurs

Example: i am having search bar in the FirstViewController. While try to access the search bar like

searchBar.searchBarStyle = .minimal

I am getting ** Assertion failure in UITraitCollection _Nonnull _UIGetCurrentFallbackTraitCollection(void)(), /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKitCore_Sim/UIKit-3899.13.13/_UIFallbackEnvironment.m:91

The sad part is in Xcode 11 only I am facing this issue. All the other view controllers are working fine. The one with CarbonKit is not working.

@ermalkaleci @gaojlieMan please let me know if you find any solution to this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gaojlieMan commented 4 years ago

2019-09-24 15:22:02.889176+0800 CarbonKitExample[5993:3225422] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '<ViewControllerOne: 0x10532b2b0> returned nil from -traitCollection, which is not allowed.' Your demo crash the same with my project,How can I run your demo with no crash,I hope you can solve it in your demo,Thanks.

------------------ 原始邮件 ------------------ 发件人: "Ermal Kaleci"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午3:12 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

@prakashRavi1990 @gaojlieMan checkout example project. if it works ok then your problem is somewhere else

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

etamluos commented 4 years ago

Screen Shot 2019-09-24 at 3 13 38 PM

etamluos commented 4 years ago

same bug in your example project :(

ermalkaleci commented 4 years ago

Try swift one

On Tue, 24 Sep 2019 at 10:26 AM, Phùng Văn Tùng notifications@github.com wrote:

same bug in your example project :(

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ermalkaleci/CarbonKit/issues/241?email_source=notifications&email_token=AAXJ54CQ53MWFBQ6I6M3JWLQLHFMVA5CNFSM4IZYQTO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NRIEQ#issuecomment-534451218, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXJ54FD7SA35RL4HOW4NDDQLHFMVANCNFSM4IZYQTOQ .

gaojlieMan commented 4 years ago

Yes,the same with my.but I do not know how can I slove it

------------------ 原始邮件 ------------------ 发件人: "Phùng Văn Tùng"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午4:26 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

same bug in your example project :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gaojlieMan commented 4 years ago

but My product use oc

gaojlieMan commented 4 years ago

I want to use oc in my project,yan can solve it as soon as possible

ermalkaleci commented 4 years ago

Try to return empty view controller for each tap

On Tue, 24 Sep 2019 at 10:34 AM, gaojlieMan notifications@github.com wrote:

but My product use oc

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ermalkaleci/CarbonKit/issues/241?email_source=notifications&email_token=AAXJ54BGMRW7PTHJRFLGXGDQLHGIPA5CNFSM4IZYQTO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NR6VA#issuecomment-534454100, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXJ54AY7QXIDS6SXPNF2RTQLHGIPANCNFSM4IZYQTOQ .

gaojlieMan commented 4 years ago

if your oc demo you solve it,you can tell me as soon as possible

ermalkaleci commented 4 years ago

objc example fails because of [[CarbonSwipeRefresh alloc] init

gaojlieMan commented 4 years ago

Yes,the same with me.can you solve it and update to your git as soon as possible,thaks

------------------ 原始邮件 ------------------ 发件人: "Ermal Kaleci"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午4:47 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

objc example fails because of [[CarbonSwipeRefresh alloc] init

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gaojlieMan commented 4 years ago

you can update your demo,I will download it,thanks

prakashRavi1990 commented 4 years ago

Dear @ermalkaleci,

Please download the sample pod integrated swift application.

https://github.com/prakashRavi1990/SampleCarbonKit

Here we can see the crash.

ermalkaleci commented 4 years ago

fixed

gaojlieMan commented 4 years ago

------------------ 原始邮件 ------------------ 发件人: "prakashRavi1990"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午5:01 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

Dear @ermalkaleci,

Please download the sample pod integrated swift application.

https://github.com/prakashRavi1990/SampleCarbonKit

Here we can see the crash.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gaojlieMan commented 4 years ago

Crash

gaojlieMan commented 4 years ago

picture in the email

gaojlieMan commented 4 years ago

you can update oc demo for me,thanks

ermalkaleci commented 4 years ago

v2.3.1 will be ready in a few min

gaojlieMan commented 4 years ago

Thanks

------------------ 原始邮件 ------------------ 发件人: "Ermal Kaleci"notifications@github.com; 发送时间: 2019年9月24日(星期二) 下午5:10 收件人: "ermalkaleci/CarbonKit"CarbonKit@noreply.github.com; 抄送: "ｘ噺嫙ぁ侓"401633128@qq.com; "Mention"mention@noreply.github.com; 主题: Re: [ermalkaleci/CarbonKit] iOS 13 Crash and just find issues.Pleaserepair it as soon as possible. (#241)

v2.3.1 will be ready in a few min

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

etamluos commented 4 years ago

thanksssss