search

ermig1979 / AntiDupl

A program to search similar and defect pictures on the disk
https://ermig1979.github.io/AntiDupl
MIT License
1.23k stars 92 forks source link

Cannot change default configuration #174

Open AlexanderLJX opened 1 year ago

AlexanderLJX commented 1 year ago

I tried changing the configurations but it doesn't seem to work. Using the search just searches with the default settings even after I have changed the settings and it just reverts back to the default when I check the settings again after performing a search.

For example, here I set the ThresholdDifference to 50 and perform a search but it still searches with the default ThresholdDifference of 5

image

I tried using the latest release and building from source but both don't work. The previous v2.3.10 release is able work, but it doesn't have the "auto delete but Saati Index" function.

heinrichI commented 1 year ago

I confirm the bug, I'll see how the time will be.

heinrichI commented 1 year ago

@Edi61 Right now CoreCompareOptions is designed to store options and setting is done by calling the CoreLib property. I don't want this usage in AntiDupl.NET.WPF. I want to set the property in C++ immediately when setting the property in C#. Should I make a separate option model in AntiDupl.NET.WPF?

Edi61 commented 1 year ago

Hi @heinrichI, It seems that I have forgotten to implement the loading/storing of the CoreOptions, but it's not handled by Corelib. Same problem should there for all core options, not only CoreCompareOptions.

In AntiDupl.NET.Winforms the storing and loading is handled by the "Load" and "Save" methods from CoreOptions. Why not handle it the same way when opening and closing the MainViewModel? see also https://github.com/ermig1979/AntiDupl/blob/fa16b22687b9ca60f203aed5f37f975a6b385300/src/AntiDupl.NET.WinForms/Form/MainForm.cs#L59 https://github.com/ermig1979/AntiDupl/blob/fa16b22687b9ca60f203aed5f37f975a6b385300/src/AntiDupl.NET.WinForms/Form/MainForm.cs#L103

kamikaze00007 commented 1 year ago

Hey, uh, sorry to interject here. But could the configuration being unable to be changed related to the issue why CompareInsideOneFolder and CompareInsideOneSearchPath doesn't work for me even if I have either one turned On or Off? I have my own issue submitted here too, detailing the problem. Basically, no matter which I turn on or turn off, the program is searching duplicates outside of a single folder, even when I want it to just do comparisons of images inside a single folder. It either doesn't find anything at all, or it looks for comparisons outside of the specified folder and into other folders. Here's my report: https://github.com/ermig1979/AntiDupl/issues/173