search

ermig1979 / AntiDupl

A program to search similar and defect pictures on the disk
https://ermig1979.github.io/AntiDupl
MIT License
1.3k stars 93 forks source link

Images are incorrectly labeled as Error #45

Open Thanatomanic opened 5 years ago

Thanatomanic commented 5 years ago

When I run AntiDupl on my collection of images, a large part gets labeled 'Error'. I believe there is nothing wrong with my images, since they display perfectly fine in Windows Photo Viewer, IrfanView, Adobe Photoshop, and even in AntiDupl itself. I see no obvious patterns: there are images from different camera's, either straight out of camera / phone or processed in software. Could this simply be due to a outdated version of OpenJPEG (version 1.5.0 dates back to 16 June 2015)?

Screenshot: image

Sample images to test (these all give 'Error' for me): https://filebin.net/drsv5y6137jx502g

ermig1979 commented 5 years ago

I downloaded your test images. AntiDupl didn't find any defected images. So I can't reproduce the bug. May be you changed some program options?

LTGM commented 5 years ago

I actually have the same issue. And a lot of images of mine are also flagged as 'error' but they are 100% working fine, no issues with them at all. Can we disable this thing somehow and leave duplicates only?

ermig1979 commented 5 years ago

https://ermig1979.github.io/AntiDupl/data/help/english/index.html?page=options.html

Defect -> Check on defect

Thanatomanic commented 5 years ago

Could you explain what the checkbox does? Does it simply skip the "defective" files if it is unchecked, and report the files if it is checked? In any case, I wonder why (sometimes?) my images are marked as defective, when clearly they are not.

ermig1979 commented 5 years ago

Many many years ago when downloading of picture take a lot of time sometimes. If connection with server was broken then the end part of the picture was not downloaded. AntiDupl checks availability of JPEG end marker. If it is absent then AntiDupl signalizes that image is defective. I checked the pictures - they have the marker. Another variant is that gdiplus.dll (standard library for Windows XP and above) can't open the image. I don't know why the library can't open the pictures.

LTGM commented 5 years ago

https://ermig1979.github.io/AntiDupl/data/help/english/index.html?page=options.html

Defect -> Check on defect

I have this option disabled and issue is still present. I turned it on, checked, turned off, checked, on and off, its not working, I still get tons of them. Can you explain?

LTGM commented 5 years ago

I guess nobody seems to care anymore and this project is abandoned?

Thanatomanic commented 5 years ago

I got a quick reply from @ermig1979, so I wouldn't call it abandoned in that sense.

I am curious: @ltgm do you encounter "errors" also on small sets of images?

LTGM commented 5 years ago

I got a quick reply from @ermig1979, so I wouldn't call it abandoned in that sense.

I am curious: @LTGM do you encounter "errors" also on small sets of images?

It doesn't matter really, I get them all the time under any conditions and settings. My point is there was no update in a long time and I saw similar thread ages ago with no respond so it probably will be never fixed.

ermig1979 commented 5 years ago

I repeat: I can't reproduce the error on my machine and accordingly I can't fix it. The source code of AntiDupl is available. So we will wait for someone who reproduces the error and fixed it.

LTGM commented 5 years ago

I repeat: I can't reproduce the error on my machine and accordingly I can't fix it. The source code of AntiDupl is available. So we will wait for someone who reproduces the error and fixed it.

Frankly I don't understand how its even possible I tried it on 4 machines with different OS, specs and so on and every time I had this issue no matter what type of content (jpg/png, photos/art/my own photos/screenshots), I still have dozens of them every time. And this check for defects switch is doing nothing, I can't disable it in the first place I just don't need that option at all.

I got a quick reply from @ermig1979, so I wouldn't call it abandoned in that sense.

I am curious: @LTGM do you encounter "errors" also on small sets of images?

Does the switching this check-for-defects option works for you?

ermig1979 commented 5 years ago

I cloned the repository and built the project. The option "check-for-defects" is work fine.

Thanatomanic commented 5 years ago

@LTGM For me the option also works does not work, but @ermig1979 I am still a little confused on what it actually does. Please look at the following screenshots.

image This image is flagged as "Error", however...

image The exact same image is successfully checked against a duplicate.

This implies that "Error" images are actually still being used for comparison. Am I correct? If so, labelling them as "Error" makes no sense to me, because... what is the error?

Also, if you uncheck "Check for defects", images with "Error" still show up, similar to what @LTGM reports. So either the checkbox is not working, or it does something completely different.

Edit: proof of this image

(For completeness sake: I am also using a build from the current repo)

heinrichI commented 5 years ago

Uncheck all check checkbox. Reason off tag error is high blockiness or bluring. By absolute values, these indicators can tell little about the quality of the image, so I do not use this.

LouisVA commented 4 years ago

Solution by @heinrichI seems to work for me :)