Should _M_ARM64 be also tested for ARM64 definition? - Githubissues

ermig1979 / Simd

C++ image processing and machine learning library with using of SIMD: SSE, AVX, AVX-512, AMX for x86/x64, VMX(Altivec) and VSX(Power7) for PowerPC, NEON for ARM.

http://ermig1979.github.io/Simd

MIT License

2.05k stars 409 forks source link

Should _M_ARM64 be also tested for ARM64 definition? #234

Closed s-trinh closed 1 year ago

s-trinh commented 1 year ago

By looking at some Neon code, it looks like _M_ARM64 is also tested along with __aarch64__, see:

https://github.com/libjpeg-turbo/libjpeg-turbo/blob/eb0a024af2d84467b22484a89e98e25b3c38025a/simd/arm/jccolor-neon.c#L56

https://gist.github.com/shibayan/8839930e07898cae4de7be91bff9d5f6#file-libwebp_arm64-patch-L36

https://stackoverflow.com/a/66249936

Should this line be updated accordingly?

https://github.com/ermig1979/Simd/blob/74366a147d49a1346019a5ffc89ad14ab1ec42dc/src/Simd/SimdDefs.h#L196

ermig1979 commented 1 year ago

Hi! This is correct note. Although this macro has to be defined in different line. I added it (see last commit).

s-trinh commented 1 year ago

Thanks :+1: