search

erming / resume-editor

http://registry.jsonresume.org/
271 stars 72 forks source link

Generate JSON that conforms to json-resume schema #8

Closed thomastoye closed 10 years ago

thomastoye commented 10 years ago

Fixes #7

erming commented 10 years ago

Hey @doublet , thanks for noticing this bug!

I've fixed it here: https://github.com/erming/resume-editor/commit/447932e0ccbfab3ff8686d0e5c549ed453e782e1

Your pull request had two problems though:

  1. Your change broke the live edit. It needs the data in the form of {"resume": <data>}.
  2. It seems you branched from an old commit.. error_branch

.. so when I clone your pull request, it doesn't run correctly.

Anyway, your fix is now in place.

Thanks!

erming commented 10 years ago

Ping https://github.com/erming/resume-editor/issues/7

thomastoye commented 10 years ago
  1. Woops, didn't notice that
  2. Hmm, that's probably because I branched off from the json-builder branch - it seemed the most logical choice :)