Change user buttons to as. Allows highlighting on firefox.

erming / shout

Deprecated. See fork @ https://github.com/thelounge

MIT License

3.62k stars 272 forks source link

Change user buttons to as. Allows highlighting on firefox. #571

Closed AlMcKinlay closed 8 years ago

AlMcKinlay commented 8 years ago

On firefox, we can't copy the usernames when it is a button. Change to span.

astorije commented 8 years ago

Any side effect on this? In particular, empty hrefs tend to not be consistently working. I'll look into it, and if so maybe href="#" would do the trick. Nice catch though! :-)

astorije commented 8 years ago

Dumb dumb dumb dumb me! I clicked "Merge" instead of "Comment", and force of daily habit I confirmed the merge right before realizing I made a mistake! Duh!

Sorry but do you mind reopening a PR please? :-/

AlMcKinlay commented 8 years ago

Hmmm, github says that there are no differences now between my branch and master, so I can't open a new PR.

AlMcKinlay commented 8 years ago

Also, woops I did mean to put href="#", not sure why I didn't. I'll update that.