search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.62k stars 272 forks source link

Parse colors in range 16-31 #586

Closed xPaw closed 8 years ago

xPaw commented 8 years ago

Fixes #583.

Some clients/bots send colors in that range, and they should map to the existing colors.

astorije commented 8 years ago

I'm :+1: for the solution, but can you give an example of the problem please? I'm just not sure to understand why we need that yet, so details are welcome :-)

Also, since this is a change in clients/libs/, would #562 affect this?

Thanks for your contribution! :-)

MaxLeiter commented 8 years ago

As far as I can tell, everything in the client/libs/handlebars is a lib just for shout, and will stay there after the dependency refactor/ (they're not on npm or another package manager and that's where they belong)

astorije commented 8 years ago

Great, thanks for the clarification!

astorije commented 8 years ago

@xPaw, just waiting for more details before I can give a formal :+1: :-)

MaxLeiter commented 8 years ago

@astorije “Some clients/bots send colors in that range”, so I assume that, atm, they either have no color or the color code is shown in the message

xPaw commented 8 years ago

@MaxLeiter color code is shown in the message. Looking at some other clients, they don't show the color code even if it doesn't map into any valid color (16-99)

My pull request might not be a good fix actually. It probably should hide color codes instead.

astorije commented 8 years ago

@xPaw, what's your plan on this then? Should we close this PR until you come up with a better one?