search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.62k stars 272 forks source link

Render user actions separately #588

Closed xPaw closed 8 years ago

xPaw commented 8 years ago

This fixes #577, #404.

Needs to be done before merging this:

dgw commented 8 years ago

What I can see of the previews from my phone looks good. Perfect or not, this is a big step forward from how it looks now. :+1:

dgw commented 8 years ago

See #571, though. The user button elements were changed to a to allow copying the text in Firefox. The new tpl should use as too.

dgw commented 8 years ago

Never mind, it moved to #574 and still needs review. But the change will probably be merged.

xPaw commented 8 years ago

I've tweaked the action texts, and it now looks like this:

yoloswag_ _shout_-_google_chrome_2016-01-17_22-22-33

xPaw commented 8 years ago

Also formatted /me actions and added "Notice" prefix to notices.

wowtest_ _shout_-_google_chrome_2016-01-17_22-45-14

MaxLeiter commented 8 years ago

+1 looks awesome

astorije commented 8 years ago

@xPaw, I left you a bunch of minor comments inline. This looks pretty awesome, really! I hope we can merge that soon :-)

xPaw commented 8 years ago

I've added displaying kick/part/quit messages, which will fix #404. However for this to work, slate-irc needs to be updated to the latest version, so that the message is passed through correctly.

EDIT: #597

xPaw commented 8 years ago

@astorije I've added font awesome icons, looks pretty cool.

chrome_2016-01-23_17-26-38

EDIT: Made topic changes green: chrome_2016-01-23_17-29-55

astorije commented 8 years ago

EDIT: Made topic changes green:

Wheren't you against bold/italic/colors in topic line? I'm OK with anything at the moment really.

astorije commented 8 years ago

These do look pretty cool... I look forward to that! :-)

xPaw commented 8 years ago

Changed icons as per feedback

chrome_2016-01-24_12-01-16

Wheren't you against bold/italic/colors in topic line? I'm OK with anything at the moment really.

You are right, I've removed green again. And I would argue it's not the best idea to make it a separate line too.

astorije commented 8 years ago

I don't think this should have been merged already, while the discussion was ongoing... but nevermind...