search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.63k stars 273 forks source link

Update dependancies #611

Closed xPaw closed 8 years ago

xPaw commented 8 years ago

I hope I didn't miss any breaking changes. Couldn't update socket.io as it kept complaining about parse error.

astorije commented 8 years ago

Hey @xPaw, thanks for this! Don't you think we should have one PR per upgraded prod dependency (and an additional one for all devDependencies)? I believe it would be easier to review, to test and to potentially debug :-)

AlMcKinlay commented 8 years ago

@astorije I would agree for breaking changes. I think it's fine to keep everything else in the same one, but let's keep lodash in a different PR as it's such a big jump. We can test it for a bit and make sure nothing else has gone wrong. I might have time sometime later this week to also read through the breaking changes.

@xPaw Did you remember to check both the 3.x and the 4.x breaking changes for lodash?

xPaw commented 8 years ago

@YaManicKill I did, yes.

astorije commented 8 years ago

I agree with @YaManicKill. @xPaw, do you mind opening a PR just for lodash? :)

xPaw commented 8 years ago

This PR now only upgrades cheerio and moment, and drops ^ ~ from versions

williamboman commented 8 years ago

drops ^ ~ from versions

Wouldn't it be better to bump versions to the latest version within the current semver range as well? This PR effectively downgrades most deps.

astorije commented 8 years ago

@williamboman, the transition is awkward for sure, but it's the safest way to go on long-term.

@xPaw, what about removing ~/^-ranges as we upgrade the versions, and keep these to the packages we haven't upgraded yet, unless this is already the latest version? I feel it's a good compromise.

xPaw commented 8 years ago

You're right about versions, I've upgraded them. Left out lodash as there's a separate PR, and socket.io because it breaks, and the client lib needs updating too.

AlMcKinlay commented 8 years ago

Oh? What breaks about socket.io? I did a quick upgrade of it sometime past and didn't notice anything, but I didn't look at everything, and didn't look at the release notes for breaking changes.

I'll add a ticket for that specifically, because it'd be good to upgrade that as there are a number of issues with the version we are currently on.

xPaw commented 8 years ago

The page kept reloading for me due to a decoding error.

MaxLeiter commented 8 years ago

Discussion on updating client libs is here just in case people cant find it: https://github.com/erming/shout/issues/562

xPaw commented 8 years ago

Closing in favor of https://github.com/thelounge/lounge/pull/8