search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.63k stars 273 forks source link

Initial work on context menus #613

Closed xPaw closed 8 years ago

xPaw commented 8 years ago

chrome_2016-01-25_15-47-56

MaxLeiter commented 8 years ago

Just adding my two cents: I think on mobile the context menu should exist elsewhere as a button, similar to the 'leave' one. Perhaps we can replace the current leave channel ('x') button with a dropdown arrow?

xPaw commented 8 years ago

I would rather try to make long press work instead of adding arrows.

AlMcKinlay commented 8 years ago

I agree with @xPaw

For a button to work, we would need to increase the size of the sidebar, as trying to hit a button on that small name is near impossible currently (it's hard enough to hit the expando for link expander just now as it is).

MaxLeiter commented 8 years ago

If long press opens a context menu then how would mobile users rearrange channels and servers?

xPaw commented 8 years ago

At least in Chrome on Android long press simply selects the text, you can't rearrange servers.

xPaw commented 8 years ago

Figured out how to make the context menu work on mobiles, by adding user-select: none; on the sidebar.

photo_2016-01-30_23-13-13

AlMcKinlay commented 8 years ago

I really like this so far, looks really nice and it brings forward many features to the user, especailyl on mobile.

I think having a longpress on mobile, and right-click on desktop works really nicely as these are things people expect to do something like that.

MaxLeiter commented 8 years ago

I agree that longpress make sense on mobile, but I think there should be a way to reorganize channels and servers. That could be built into the context menu (ie “unlock” or “move down”) but that seems like an awkward UX choice

AlMcKinlay commented 8 years ago

We could have a "grabber" (I forget what the proper word for them is) on touch-screen devices that you can use for reordering.

xPaw commented 8 years ago

The question is why current grabbing stuff does't work on mobile. That should be triggered long before the contextmenu event.

EDIT: Shout is using sortable from jQuery UI, and that doesn't work with mobile events by default. Including https://github.com/furf/jquery-ui-touch-punch/ makes it work.

xPaw commented 8 years ago

Closing this in favor of https://github.com/thelounge/lounge/pull/9