search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.62k stars 272 forks source link

Rotate part/quit icon #617

Closed MaxLeiter closed 8 years ago

MaxLeiter commented 8 years ago

Before:

image

After:

image

Before, the icons were aiming the same direction. That threw me off and I feel that this looks better (and better represents leaving)

astorije commented 8 years ago

Yes! Big :+1: on that! This is among the list of things that I noticed could be improved from #588 (so many thanks to @xPaw!). It does look much better indeed!

Just one thing, could you squash these into 1 commit and keep the "Rotate part/quit icon" message please? (Also, small detail, if you look at the CONTRIBUTING file and best practices in Git, always phrase your commit message with infinitive tense)

@xPaw, just curious, are you OK with this? :-)

Thanks @MaxLeiter!

MaxLeiter commented 8 years ago

Bump

JocelynDelalande commented 8 years ago

Ok, reviewed, makes sense. Once CSS vendor-prefixes are dropped as suggested by @xPaw , you get my auto-:+1: :-)

MaxLeiter commented 8 years ago

Bump :)

astorije commented 8 years ago

@MaxLeiter, squashy squash? :) I'll merge afterwards.