Request for notification approval on page load if the setting is enabled

erming / shout

Deprecated. See fork @ https://github.com/thelounge

MIT License

3.62k stars 272 forks source link

Request for notification approval on page load if the setting is enabled #629

Open xPaw opened 8 years ago

xPaw commented 8 years ago

Currently you can have to disable/enable the setting to get the "page is asking for notification access" popup.

AlMcKinlay commented 8 years ago

Why would we ask for permission when the user hasn't asked us to show them notifications yet?

xPaw commented 8 years ago

The problem is that the notifications are enabled by default in Shout's settings, so the behaviour is quite inconsistent.

AlMcKinlay commented 8 years ago

Wait, are they? I thought badge was set to false by default.

xPaw commented 8 years ago

That's interesting. It is indeed badge: false in the code. I guess I clicked close button some time ago when it asked for notifications.

AlMcKinlay commented 8 years ago

Ah yes, that does bring up another bug. If you choose to enable the notification setting, but don't accept notifications, then you have to disable it and enable it again before you get asked again. We should probably think of a solution to that.