search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.62k stars 272 forks source link

Allow shout-irc to be hosted behind a /path/ in a proxy #637

Closed gdamjan closed 6 years ago

gdamjan commented 8 years ago

Typical nginx config is:

  location /irc/ {
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";
    proxy_pass http://localhost:9000/;
  }

ps. the trailing /s are important both in location and proxy_pass.

the changes make all the urls that shout-irc uses to be relative.

AlMcKinlay commented 8 years ago

Looks good. Nice and simple, I'll have a play around to double check you didn't miss anything, but it does seem to be all that's needed. I was about to ask about the JS files, but it seems they are already relative.

gdamjan commented 8 years ago

fixes #333 #346

MaxLeiter commented 8 years ago

@gdamjan might want to squish the commits, otherwise looks good :) :+1:

gdamjan commented 8 years ago

i'll do that as soon I get home tonight

astorije commented 8 years ago

FYI, this has been implemented in The Lounge: https://github.com/thelounge/lounge/pull/3 and https://github.com/thelounge/lounge/pull/20.

I'm wondering if we should fix these (PRs that have made it to The Lounge).

gdamjan commented 8 years ago

updated

gdamjan commented 6 years ago

not going anywhere

MaxLeiter commented 6 years ago

@gdamjan in case you didn't see from @astorije's comment, Shout is now inactive, and it has been continued as TheLounge over at https://github.com/thelounge/lounge

gdamjan commented 6 years ago

yeah I know, the same patch was accepted in thelounge. it was jut annoying me in the github pr page