erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.63k stars 273 forks source link

Fix: colored nicknames for new info messages design #663

Closed bews closed 8 years ago

bews commented 8 years ago

Now they're colored too (if colored nicknames option is enabled).

2016-05-05_08-19-44

astorije commented 8 years ago

@bews, do you mind re-opening this on The Lounge as well? We are missing this over there and that would be a great addition!

I believe this is the case, but just double-checking this: Are the colors in the action strings (joins, quits, ...) the same than the ones for message authorship? That is, if I join and then post a message, will the color be the same?

Also, careful, you have an unintended commit here Well, 2 unintended commits now :-)

bews commented 8 years ago

Also, careful, you have an unintended commit here :-)

Already noticed :)

Are the colors in the action strings (joins, quits, ...) the same than the ones for message authorship? That is, if I join and then post a message, will the color be the same?

Yep.

astorije commented 8 years ago

Already noticed :)

Now you have 2 :-)

git rebase -i master
# Remove the last 2 commits and save
git push --force
dgw commented 8 years ago

Ah, the perils of making PRs from your master branch.

bews commented 8 years ago

Recreated from branch - #664