search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.63k stars 273 forks source link

Colours appearing incorrectly inside angle brackets #674

Open Alligator opened 8 years ago

Alligator commented 8 years ago

We are using discord-irc to bridge our discord and IRC channels. discord-irc automatically colours nicknames in the IRC messages it sends to match their discord colour, but in shout these appear incorrectly, for example:

image

However, if I refresh the colours appear correctly:

image

Here is the raw IRC message, as captured from weechat (host/channel removed):

:db!~db@host PRIVMSG #channel :<\x0310alligator\x0F> test

I am assuming this is something to do with detecting nicks enclosed in <>, as the span ends up with a data-chan attribute, but as you can see the markup is pretty wild:

<span class="inline-channel" role="button" tabindex="0" data-chan="<<span">&lt;<span< span=""> class="irc-fg10"&gt;alligator</span<></span>

dgw commented 8 years ago

Would you be open to testing The Lounge with this setup? If it's an issue there, it would be good to know before 2.0.0 releases.

Alligator commented 8 years ago

@dgw I don't see this issue in the lounge on version 1.5.0 or 2.0.0-pre.2

dgw commented 8 years ago

@Alligator That's good news! Shout isn't maintained very much these days, which is why its readme points to The Lounge.