search

erming / shout

Deprecated. See fork @ https://github.com/thelounge
MIT License
3.63k stars 273 forks source link

Object fall-through added #692

Closed Rafi993 closed 6 years ago

Rafi993 commented 6 years ago

I have replace switch in some places with object fall-through. It could be done in the other places too. Even-though it does not add any functionality it reduces unwanted break and return in the code.

MaxLeiter commented 6 years ago

Hey @Rafi993 - shout is now inactive. I recommend checking out it’s successor project TheLounge at https://github.com/thelounge/lounge

astorije commented 6 years ago

Like @MaxLeiter said, Shout is inactive and further development happens on https://github.com/thelounge/thelounge. I am going to close this PR because it currently just deletes the entire repo, and it would be terrible if it got merged by accident.

dgw commented 6 years ago

@astorije This is why I always discourage people from opening PRs from master on projects I manage. One day you'll forget that master is a PR source branch, and push stuff to it that shouldn't be merged.