Fixed Overlay - Githubissues

ermiyaeskandary / Slither.io-bot

Just for fun and AI. Written in Javascript, this is a project which the aim is to make a computer play against humans inside a human-driven game, which is in this case Slither.io. The goal is simple - try and make the snake live and get as long as possible.

Mozilla Public License 2.0

195 stars 124 forks source link

Fixed Overlay #295

Closed Salvationdk closed 8 years ago

Salvationdk commented 8 years ago

Description

Moved status div box down to avoid the overlay starting in the menu box.

TESTING STAGE

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:

[x] I have read CONTRIBUTING.md
[x] I fully understand the Github Flow and I'm merging into the develop branch , which is the default branch, and not the master branch
[x] My code adheres to the code style of this project but most importantly of all to the things mentioned, which I have read, in CONTRIBUTING.md
[ ] If my change requires a change to the documentation, I have updated the documentation in /docs accordingly.
[ ] I have included the results of the test required.

statusOerlay DIV moved down to avoid overlap with menu

ermiyaeskandary commented 8 years ago

Why? What's wrong with the current overlay ?

Salvationdk commented 8 years ago

it overlaps the menu on scores data

Salvationdk commented 8 years ago

nofix-fix

ermiyaeskandary commented 8 years ago

@Salvationdk It doesn't for me and I've just reinstalled it from the develop branch :confused:

Salvationdk commented 8 years ago

font is different than mine...

Salvationdk commented 8 years ago

http://stackoverflow.com/questions/10450091/consolas-smaller-than-verdana

ChadSki commented 8 years ago

We should fix this once and for all by using some sort of stackpanel instead of absolute coordinates.

ermiyaeskandary commented 8 years ago

Confirmed by changing fonts. I'll go with the benefit of the doubt and be cautious so I'm merging with develop... :+1: