Custom oef (reduce food glow and other zoom maintain)

[tjorim]

Description

Create custom redraw() for foodglow, this modifies the standard one.

Remove the foodglow as suggested by @pllsner in #310 , the issue is also stated in #236 . Since this modifies the redraw()-function, the zoom is altered as well instead of calling an extra function on each redraw.

TESTING STAGE

Current bot (develop and master is the same):

• games 99
• median 1944
• average 4883

  After these commits:

• games 125
• median 2810
• average 5480

I have let a few bots run overnight, all scores where put in an excel-file where I did some quick statistics. I ran 4 bots: master, develop and 2x the custom_oef branch.

Map1.xlsx <-- Here are the results!!!

Both master and develop branches have the same bot code, you can see that the results differ a lot. This is just to demonstrate that 2 running bots can have totally different scores.

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

  Checklist:

• [x] I have read CONTRIBUTING.md
• [x] I fully understand the Github Flow and I'm merging into the develop branch , which is the default branch, and not the master branch
• [x] My code adheres to the code style of this project but most importantly of all to the things mentioned, which I have read, in CONTRIBUTING.md
• [ ] If my change requires a change to the documentation, I have updated the documentation in /docs accordingly.
• [x] I have included the results of the test required.

[tjorim]

:+1: I would say :smile:

[ChadSki]

Alright! Excited to see this change get in. I will test tonight!

[alexzeit]

1. The current zoom is not stored for the next game after respawn.
2. Suggestion: set the same one collor for all food (b=per_color_imgs[number])

I have tried to set one collor for all foods in the same way but without success, could you have a look on this:

var original_newfood = window.newFood;
var original_newfood_string = original_newfood.toString();
var newfood_string = original_newfood_string.replace(/per_color_imgs\[e.cv/gi, 'per_color_imgs[10');

window.newFood = new Function(newfood_string.substring(
newfood_string.indexOf('{') + 1, newfood_string.lastIndexOf('}'))); 

[ermiyaeskandary]

100% approved! Looks great and after (not alot of) testing, it doesn't seem to have an influence on performance - after all, it should be improving it anyway Great job @tjorim ! Approved (edit: forgot)

[ChadSki]

:+1:

[tjorim]

@alexzeit That's already in the script somewhere.

[Seple]

Please add a standard "master" code

[ChadSki]

We need more approvals! @OneEyed @chancity @MattDuffin @Drflash55 @ErmiyaEskandary @Evanito @FliiFe @K00sKlust @j-c-m @clemens-tolboom

[FliiFe]

Approved :+1:

[Evanito]

:+1: Looks good to me!

[ermiyaeskandary]

Approved (forgot otherwise I had approved it long time ago ;))

[ChadSki]

Nice work @tjorim, thanks for landing this feature! :tada:

[HamishBlank]

Performance has dropped severely after this merge. Windows 10 Firefox 47 with greasemonkey

[FliiFe]

@HamishBlank Can you try with the commit right before the merge to confirm this is the issue ?

Le mer. 29 juin 2016 00:19, HamishBlank notifications@github.com a écrit :

Performance has dropped severely after this merge. Windows 10 Firefox 47 with greasemonkey

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ErmiyaEskandary/Slither.io-bot/pull/311#issuecomment-229201749, or mute the thread https://github.com/notifications/unsubscribe/AIVeIfTbedtkAegEa-mxPcgiDdLyEeZ-ks5qQZ3-gaJpZM4I8l1k .

[HamishBlank]

commit 420e562 is the commit right before, and screen goes completely blank edit: except for the background

commit 0e3a1b4 the one before 420e562 performance is back to normal without issues

[HamishBlank]

working fine in Google chrome 51.0.2704.103 tampermonkey windows 10, only a slight/very minimal difference between 0e3a1b4 and latest

[ChadSki]

Dang, I tested in Chrome and didn't catch this. :P

Opening issue #315 to track this.