TypeError in Colab demo

ermongroup / SDEdit

PyTorch implementation for SDEdit: Image Synthesis and Editing with Stochastic Differential Equations

https://sde-image-editing.github.io/

MIT License

1.01k stars 93 forks source link

TypeError in Colab demo #2

Closed wandrzej closed 3 years ago

wandrzej commented 3 years ago

All 3 blocks for image generation produce this error: TypeError: image_editing_denoising_step_flexible_mask() got an unexpected keyword argument 'return_pred_xstart'

weihaox commented 3 years ago

Delete line 106 return_pred_xstart=False in colab_utils/utils.py.

AK391 commented 3 years ago

@weihaox still getting the error did you restart the notebook?

weihaox commented 3 years ago

@weihaox still getting the error did you restart the notebook?

Yes, you need to restart the notebook. It seems that modifications in colab would take some time to become effective. You can add some print command to see if the modified script is working.

chenlin9 commented 3 years ago

Thank you for starting the discussion. The issue in the notebook should be fixed now. We updated colab_utils/utils.py line 106, return_pred_xstart=False is now removed. Let us know if there are any other issues with the notebook! Thank you!

chenlin9 commented 3 years ago

Delete line 106 return_pred_xstart=False in colab_utils/utils.py.

Yeah, that seems to be the issue. Thank you for pointing that out!