ermongroup / cs228-notes

Course notes for CS228: Probabilistic Graphical Models.
MIT License
1.9k stars 471 forks source link

Clarification in Belief Propagation notes #195

Closed mr-easy closed 4 years ago

mr-easy commented 4 years ago

In the section Max-product message passing,

The key observation is that the sum and max operators both distribute over products.

I think this holds true only because the factors are always positive and might not hold in general. And should be mentioned in the notes.

chrisyeh96 commented 4 years ago

Good point. Addressed in commit 8002af5.