search

ermtl / Open-Source-Ventilator

Complete control software for an emergency medical ventilator.
GNU General Public License v3.0
52 stars 30 forks source link

eeprom_crc: add eeprom functions for consistency #24

Closed javierfileiv closed 4 years ago

javierfileiv commented 4 years ago

Added funtions to verify consistency on eeprom memory

ermtl commented 4 years ago

Hi, looks like our change conflict, for we changed the same parts. Also, you made a .h file in the same directory as the main one for just 1 function. That's not the way it's generally done in Arduino. Another point is I would like to have a CRC just for the struct and not the whole EEPROM, as it then becomes possible to have a second copy of the data and if the first fails, the second is used, but for that, each must have it's own CRC.

javierfileiv commented 4 years ago

It's ok... I don't feel comfortable with this environment. You can close this PR :)

Blimpyway commented 4 years ago

If an unlikely event as eeprom writing has failed I would suspect something is really wrong with the machine and avoid use it anymore. I mean if you assume it happened twice then it is really, really time to dump it.

ermtl commented 4 years ago

@javierfileiv Thanks for the attempt and sorry to learn that you don't want to work within the Arduino development system.

FYI, here is the library I'll be using https://github.com/bakercp/CRC32