search

ernestlim8 / pe

0 stars 0 forks source link

assignmacro #3

Open ernestlim8 opened 3 years ago

ernestlim8 commented 3 years ago

image.png

image.png

image.png

After adding in the macro, test does not show any error message or output. Using the listmacro command, the macro test exists but cannot be called

nus-se-bot commented 3 years ago

Team's Response

It has already been written in the user guide and explained in the developer guide, that a vaild assignmacro command does not guarantee that the saved command is valid, as we give flexibility to the user to save partial commands into a macro, so that the macro used with different sets of additional arguments. Refer to the 2nd example of assignmacro command in the user guide for a concrete example.

Nonetheless, an error message for the respective commands will be shown if the macro is used in such a way that the underlying command is incorrect.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The command test does not give any error message, even though it is an invalid command. Similar to your second example, the partial command does not give an error message, such that the user is unaware whether it is an incomplete command.

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: This causes occassional inconvenience to users who are not familiar with the syntax for the commands that assigned to the macro as they might not remember which part of partial command they inputted.

Using your example in your UG, assigning 'update ct/w pd/panadol t/fever' to macro uwp. When uwp is typed out, there is no feedback to the user that the command is incomplete. This forces the user to key in listmacros to remember what they set as the macro, which causes inconvenience.