search

erniebrodeur / pushover

A gem to interface with pushover.net
http://erniebrodeur.github.io/pushover/
MIT License
64 stars 24 forks source link

Bump HTTParty Version #21

Closed maddox closed 9 years ago

maddox commented 9 years ago

This bumps the version of HTTParty used and does not lock directly to it.

This allows pushover to coexist nicer with other gems that use HTTParty.

All tests pass.

maddox commented 9 years ago

Hrmm, maybe not. I only ran it on 2.0 :/

erniebrodeur commented 9 years ago

Hey maddox, I'll check this out, I wanna switch away from httpparty entirely and redo the code but haven't had time. Mind you, all my specs are now failing with the update, so if that isn't fixed, I couldn't merge this without work anyway.

erniebrodeur commented 9 years ago

Gem::InstallError: httparty requires Ruby version >= 1.9.3. An error occurred while installing httparty (0.13.5), and Bundler cannot continue. Make sure that gem install httparty -v '0.13.5' succeeds before bundling. The command "eval bundle install --without development" failed. Retrying, 2 of 3.

Looks like updating httpparty breaks things.

I want to switch to excon, I will check out #22 though.

maddox commented 9 years ago

Yeah i assume it's httparty's requirements.

maddox commented 9 years ago

Yup, there it is, heh.

maddox commented 9 years ago

22 has this branch inside it already though :/ I was working on the assumption that my changes were perfect :ok_hand: lol.

We can just close these if you want. I just dropped the code in my project manually to get stuff working.

erniebrodeur commented 9 years ago

Understood, thanks for the issue, I do like the fact you are using. I hope to rewrite it, learned a lot in the last few years.