search

erniebrodeur / pushover

A gem to interface with pushover.net
http://erniebrodeur.github.io/pushover/
MIT License
64 stars 24 forks source link

Need to include the version. #33

Closed ianbrown78 closed 5 years ago

ianbrown78 commented 5 years ago

The version is not included, so causes a Pushover::VERSION uninitialized variable error when attempting to use the gem.

codecov-io commented 5 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #33   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          30     30           
=====================================
  Hits           30     30
Impacted Files Coverage Δ
lib/pushover.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e8faf9...f34bdc3. Read the comment docs.

erniebrodeur commented 5 years ago

this is fixed in dev, but bumped in master. not sure why, it's a dupe of an existing bug.

I'll sort the gem out today or tomorrow and release 3.0.2, but I may not end up merging this branch, ty for the bug report though.

erniebrodeur commented 5 years ago

merged dev to master, so gonna close this, but you should be good to go with 3.0.2, which I just released.