search

ernoaapa / eliot

Open source system for managing containerized applications in IoT device
https://docs.eliot.run
Apache License 2.0
269 stars 20 forks source link

Fix discovery server not stopping properly #38

Closed ernoaapa closed 6 years ago

ernoaapa commented 6 years ago

Previously discovery.Server hang if Stop() were called and never actually close. There were missing make(chan).

codecov[bot] commented 6 years ago

Codecov Report

Merging #38 into master will increase coverage by 1.45%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   24.02%   25.48%   +1.45%     
==========================================
  Files          50       50              
  Lines        2439     2433       -6     
==========================================
+ Hits          586      620      +34     
+ Misses       1789     1746      -43     
- Partials       64       67       +3
Impacted Files Coverage Δ
pkg/discovery/server.go 90.9% <100%> (+90.9%) :arrow_up:
pkg/discovery/client.go 77.77% <75%> (+77.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ace815...34ddabd. Read the comment docs.