search

ernstc / SqlDataInspector

This is an Azure Data Studio extension that let you inspect the data in your database with just few clicks.
MIT License
51 stars 6 forks source link

"Find in Results Grid" feature like SSMSBoost had for SSMS #15

Open gregclerk opened 1 year ago

gregclerk commented 1 year ago

SSMBoost (now abandoned) had this feature for SSMS: Find in Results Grid

Would it be possible to add this sort of feature to this SqlDataInspector extension?

Thanks!

Tix2garr commented 3 months ago

That would be pretty nice. :-)

ernstc commented 3 months ago

Thank you for this feature request. Actually the results are loaded only for the selected page, so if you mean searching data in the loaded page results it should not be a problem. But if you mean searching through all the results for the query, in all pages, this can be an heave task for those tables with thousands or millions or rows.

gregclerk commented 3 months ago

I was referring to the entire result set like SSMSBoost does (that add-in has actually been resurrected but is only for SSMS not Azure Data Studio).

Is this a VS Code issue where it only loads the current page? It's strange because SSMS performs much better with displaying/copying large result sets than Azure Data Studio.

Thanks

ernstc commented 3 months ago

It's not an issue of VS Code or Azure Data Studio. The Grid result that you see in the extension is part of the extension and has limited capabilities because it is a new Grid. It is not the same grid that you see when you execute the query in a normal Query page.

The grid in the extension loads only the selected page for performance reasons. You can change the size of the page up to 100 rows. Searching in the entire resulting dataset is just a performance concern for both Azure Data Studio and for the DB server in case of very huge datasets.