erogenousbeef-zz / BigReactors

Big Reactors mod for Minecraft
MIT License
153 stars 102 forks source link

yellorite generation issue? #315

Closed archmon closed 10 years ago

archmon commented 10 years ago

Just noticed that there is no yellorite in the underdark despite going though retrogen. also went out a ways and did not find it. Might be something to look into to make sure yellorite generates in mystcraft ages and in dim like the underdark that people like to use for quarrying.

On the plus side, retrogen works in the overworld. Using BigReactors-0.4.0rc3 and extrautilities-1.1.0i

erogenousbeef-zz commented 10 years ago

I recall hearing about this before, but I recall it being due to the Underdark using special types of stone. My code will only replace standard vanilla smooth stone.

Is there smooth stone in the underdark, or something else? Further, you may wish to confirm with ExtraUtilities that they intend for standard ore generation to run.

archmon commented 10 years ago

2014-08-29_09 22 42 I don't know for sure if this is what you call vanilla smooth stone, but it looks like it's from the minecraft mod thing according to whila.

I know there is supposed to be like 2x vanilla ore generating code for the underdark, but I'll post this topic to the extrautilities thread as well.

archmon commented 10 years ago

posted this to RWtema's page as well. https://github.com/rwtema/extrautilities/issues/284

archmon commented 10 years ago

Also, while i'm at it, what level does yellorite start to spawn in the overworld?

Want to know because I can use the blood magic ritual of magnetism to quickly bring up any ores below it and that could help with testing this issue.

erogenousbeef-zz commented 10 years ago

Yes, that's vanilla smooth stone. So, two possibiltiies:

BR skips worldgen in dimensions which meet either of these criteria:

If it's one of the those, I'll have to recognize the exception somehow, or perhaps add an explicit dimension whitelist. That's an imperfect solution, as it adds to maintenance load for modpack creators.

The maximum height is governed by the YelloriteMaxY setting, which defaults to 50.

erogenousbeef-zz commented 10 years ago

Right. The problem here is that my world generator skips negative dimensions by default. I'll add a dimension whitelist so that you can selectively unblock negative dimensions.

erogenousbeef-zz commented 10 years ago

Added a new WorldGen setting: dimensionWhitelist. If enableWorldGenInNegativeDimensions is true, you can add specific dimensionIDs to dimensionWhitelist to unblock individual dimensions.

archmon commented 10 years ago

so, is this something we will have to change in the BigReactors Config? Example if so would be wonderful.

erogenousbeef-zz commented 10 years ago

Search for:

I:dimensionWhitelist <
>

Change it to something like this:

I:dimensionWhitelist <
 -100
>

Where -100 is the dimensionID of the ExtraUtils underdark.

archmon commented 10 years ago

I assume this will be available in rc9 right?

erogenousbeef-zz commented 10 years ago

Yes.