Code clean up, efficiency improvements (slight), and bug fix

eromatiya / rofi-spotlight

Spotlight-like Rofi

MIT License

206 stars 7 forks source link

Code clean up, efficiency improvements (slight), and bug fix #16

Closed AethanFoot closed 4 years ago

AethanFoot commented 4 years ago

Title quite explanatory, bug was with string splitting with actions in the context menus and files with spaces. An example of this was opening file in text editor opening a new file with the first part of the name. Also added back button to help back (not sure if it should stay at the bottom and be at the top).

eromatiya commented 4 years ago

Nice! Thank you for this! Will merge it now!

eromatiya commented 4 years ago

Hey tested it and file/web searching seems to be broken. Note that adding a prefix eg :wb, !, ? works, but without it it doesn't. Screenshot below. ./rofi-spotlight.sh "!win10" produces a result where ./rofi-spotlight.sh "win10" does not.

eromatiya commented 4 years ago

Managed to fix it https://github.com/manilarome/rofi-spotlight/commit/3f86fc16bd7c4b4c6348e029b28ed297d9504d30