erosDiffusion / ComfyUI-enricos-nodes

Compositor Node experiments
MIT License
318 stars 10 forks source link

Opening the comfyui queue crashes the browser #66

Closed bulldog68 closed 1 month ago

bulldog68 commented 2 months ago

hello, the node blocks the display of images in confortui see crashes the browser, tested with chrome and firefox. No Tasks Found There are no tasks in the queue. Capture d’écran du 2024-09-23 16-38-18

erosDiffusion commented 2 months ago

Hi @bulldog68 the issue is there when opening the queue: Thanks for reporting.

As a temporary workaround, if you can, keep the queue/image list closed to avoid the crash.

As I'm not getting any error / exceptions in the console it's quite hard to understand what's going on but I'm investigating.

bulldog68 commented 2 months ago

yes it is a solution, on the other hand a lot of node style pythongosssss also blocks the browser when using compositor, it's a shame because this node is really handy.

erosDiffusion commented 2 months ago

so, not entirely sure I can fix this. it looks like the problem is in comfyui (or related to the node interaction with latest frontend in comfy ui), if you start with the legacy frontend there seems to be no issue:

https://github.com/comfyanonymous/ComfyUI#accessing-the-legacy-frontend to start with legacy frontend use as commandline argument --front-end-version Comfy-Org/ComfyUI_legacy_frontend@latest

I will keep on investigating. at the root I think the problem lies with stopping the current flow with /interrupt api endpoint, some thread might be stuck but there is no error in the logs. also it might be due to some frontend stuff but again, not sure yet

erosDiffusion commented 1 month ago

note, when using threaded pause #65 the application is not prone to the problem and does not crash

erosDiffusion commented 1 month ago

I'm still investigating what's causing the issue and it's cryptic. for the time being I'm closing this.

if you don't want the issue just use the legacy toolbars until they are out of beta.

image