erosb / jquery.treeview

a jQuery UI TreeView widget built on my jquery.observable lib
4 stars 1 forks source link

Doc and code issue #1

Open nevf opened 12 years ago

nevf commented 12 years ago

First up congrats on this lightweight tree view.

The first example in the readme uses: <div id="#treeview"></div> which should be <div id="treeview"></div>. ie No # in the id.

I've created a sample with checkboxes and when the tree is initially displayed the checkboxes display a ^ inside them. Clicking a check box displays correctly.

It would be nice to include some example files so folks can try the treeview without having to write any code.

Keep up the good work.

Neville

erosb commented 12 years ago

Dear Neville,

thank you for the bugreport, I have fixed the problem, see commit #967b134e

By the way how did you pitch up this project?:)

nevf commented 12 years ago

Hi Bence, Thanks for the quick fixes. I found the project when searching Github for a Treeview. I was specifically looking for some lightweight JS code. There are several full featured JS Treeview's around like http://www.jstree.com/ but they are too big and complex for my simple needs.

BTW I'm also quite interested in your jquery.observable project. I've been doing a lot of work with Knockout.js MVVM but have been looking for lighter weight and simpler code just to do two way binding. Your jquery.observable might be just what I'm after. FYI I never would have found this if it hadn't been for your jquery.treeview.

And finally the jquery.treeview readme should mention that you need to download jquery.observable as well. Or just include it the jquery.treeview download.

Neville

erosb commented 12 years ago

Hi Neville,

I have also looked at KnockoutJS after I created the initials of jquery.observable, and yes, my library would be a good back-end for that. Anyway in its current state I don't recommend using jquery.observable on its own, since it lacks some important features. Later on I would like to put together a UI system, something similar to KnockoutJS.