Firemonkey: source code

atomGit commented 4 years ago

the MPL states...

such Covered Software must also be made available in Source Code Form

i realize the source is available in the .xpi - is it published elsewhere? i couldn't find it at github, gitlab or codeberg

erosman commented 4 years ago

i realize the source is available in the .xpi -

Correct

is it published elsewhere? i couldn't find it at github, gitlab or codeberg

No. I don't use them to develop Previously: #97 #110

atomGit commented 4 years ago

for me this is rather trivial, but not publishing the source doesn't conflict with the MPL?

aside from that, publishing the source allows one to view commits

i understand and respect that you have your own workflow, but the problem i see is that SO MANY of the add-ons at AMO are what i would call malware in that they do data collection and various other nefarious stuff, or a developer will sell-out to a 3rd party or otherwise find a non-ethical way to monetize their add-on, thus why it's really nice to view the code commits and verify, separate from what the developer says, that nothing funny is going on

while this is of coarse doable by extracting the XPI and comparing versions, that is a time consuming chore that isn't practical

so i get that you have a preferred workflow and indeed appear to be an ethical person, however i respectfully ask that you (re)consider publishing the source for the sake of our your users sanity :)

if you use codeberg, they have no 3rd party dependencies

erosman commented 4 years ago

The code is not minified and easy to read. Extracting a xpi is not very cumbersome for those who are programmers and already familiar with process.

Non-programmers don't really check the code any way.

I regularly change the code and reflecting each change on a remote site is not feasible. I also develop, use and road test at the same time which is not possible when developing via internet sites.

rezad1393 commented 3 years ago

wow this is such a bad thing in today's software world. I got to this addon from ghacks site and I was so exited for an addon that uses official firefox api. but using a binary with not even a non-git source code is no longer appealing to me.

it is not just the malware concern, but also code continuity and code sharing. after using firefox for more that 15 years I cant be bothered to use addons that there are no hope of forking them if the main developer just disappears or gets tired of it.

I hope this addon owner also uses the FOSS model and let others also share their knowledge and time for development and betterment of this addon.

as the other guy said it is not just about extracting xpi. it is about having an version controlled accessible shared development that assures users that addon would not be easily abandoned.

erosman commented 3 years ago

..... version controlled accessible shared development ....

@rezad1393 There are those who develop using online tools such as Github etc. This model is best suited for shared code development where few people contribute to the code and changes do not occur too frequently.

For a single developer, who often rewrites code 10-20 times a day and makes changes, it is not possible to development via an online method.

Forking github has its pro & cons. While it helps in case a developer drops a project, in reality it has become the forte of plagiarists. As an example, there has been 100s of forks of uBlock Origin that have been uploaded to AMO by people who are not programmers (copy-pasters) and/or people who hide malicious code within good code.

There are also open-source extensions that have their code published on Github which is good but the extension code itself is minified and requires additional scripts and processes to match the code of the extension to the code published on Github.

FOSS require the software to be free and open and inspectable, and FireMonkey meets those requirements.

rezad1393 commented 3 years ago

thank you for the long and good answer. English is not my main language so maybe I was not that clear.

when I said FOSS model I meant in spirit not in strict intreperatation. I meant allowing other to be involved so that humanity as a whole benefits and we dont invent the wheel too many times. yes I mean that sincerely, and I believe that software/algorithm duplicates waste a lot of man/hours (well man/years to be honest) of humanity potential.

also I understand a lot of point you make but I cant agree with most of them.

for example (a negative example) amd graphic driver for linux are supposed to be opensource (and kinda FOSS) but amd doesnt actually share the code history. they only upload versions to github. that is a example of a bad FOSS project that wastes its own potential if it was shared with public to participate it code review in every commit. but I understand that they have to do it because of corporate issues that may pop up if they share every commit (or at least I think that is one of the reasons)

about the single developer part: even if nobody else ( and I mean literally nobody else) helped you with this it is still beneficiary to put the code here so that other benefit from it. ease of access for new programmers is very important and if they can search github (or any other code hosting for that matter ) and find your code they can learn a lot from it. also you dont need to push all your changes to github (As far as I am familiar with git). committing to git repo on github every few days the aggregates changes is not against the law :) .

also you cant stop those who want to (as you said) plagiarize it. even ublock couldnt . not uploading the code to github doesnt stop that. it actually encourages it because if you had a git history on github of your code changes you could show that you are the main (not-plagiarist) version and in extreme cases you can submit removal request to github or Mozilla for those that copy your code when they dont follow the copy-right part of FOSS (the parts about showing who the real author of original code is and so on)

but in the end it is your project and you are to do as you think is best. these are just suggestions that I just gathered from my experience with software as a end user and seeing the state of opensource software in relation to updates and codechanges and so on.

have a good day.

erosman commented 3 years ago

Thank you for the feedback :+1 Let's see what future holds.

mainrs commented 3 years ago

I regularly change the code[...].

Yes, but that doesn't prevent you from using a version control system (VCS) like git or svn. Note that git is not GitHub. git is used locally to create a repository, add files to it, commit changes and do other stuff related to development. As soon as you finished implementing a feature or fixing a bug you can simply commit the changes to the repository. No one tells you how often you have to commit. But if you'd be willing to publish a new version of the addon then you'd probably should create a commit at that point. I don't see why this would break your workflow to be honest.

Some kind of VCS should be inplace to prevent accidental breakage during programming anyway. Be it copy-pasting folders (please don't), or a traditional VCS.

[...] and reflecting each change on a remote site is not feasible.

Well, if you use a VCS like git or svn, that is free-of-charge. git push does it for you. Done.

I also develop, use and road test at the same time which is not possible when developing via internet sites.

These seems more to me that you got the idea wrong. You don't develop on any internet site. GitHub, Gitlab, BitBucket or merely mirrors of your local repository. What you do locally is up to you. You just mirror those changes and files onto a server.

I don't mean this in to be offensive in any way, I just wanted to clear up some stuff as I had the feeling that you didn't understand some concepts of VCS and remote servers. Millions of developers use internet services like GitHub to publish their source code, work on their projects locally and test them there as well. And it all works for them. If you're simply not familiar with VCS in general, I'd highly recommend to get into them. And there is nothing better than a project of yours, even if you don't upload your changes onto a remote server and only use it locally.

If you simply don't want to publish the source code "officially", that's a totally different story and that decision is up to you for sure. It's your project, your intellectual property and your decision on how to handle it. And you shouldn't feel forced to upload your code just because some people request it. In that case, maybe a pinned issue stating that you don't plan to publish the code for the foreseeable future might be a good idea. There have been a lot of people asking the question by now.

erosman commented 3 years ago

Thank you @SirWindfield for the feedback.

Well, if you use a VCS like git or svn, that is free-of-charge. git push does it for you.

I use a plain editor like Notepad++, to edit & run unpacked addon live on my Nightly (Win7). In other words, with only an editor & Nightly. How does that set-up run VCS without installing new applications?

Please consider that ...

Programmers, shouldn't have any problem extracting the XPI and inspecting the code
Non-programmers would find it difficult to inspect the code even if it was on Github

Furthermore ...

Tampermonkey with the largest user-base in user-script mangers on Firefox (421,000+ users) & Chrome (10,000,000+ users), not only doesn't git its code, but is Proprietary License and minified
Stylish with the largest user-base in user-style mangers on Firefox (74,000+ users) & Chrome (2,000,000+ users), not only doesn't git its code, but is Proprietary License and minified
Violentmonkey on Firefox (43,000+ users) & Chrome (600,000+ users) code is minified and a compile script is needed to compare the addon code with the published github code
Greasemonkey on Firefox (283,000+ users) code is clear and on github but it is worked on by more than one person

AFA Tampermonkey & Stylish, nearly 12.5 million users don't mind not seeing the code. FireMonkey only has 440 users ATM. :wink:

I am happy to answer any queries regarding the code and will consider all code improvement suggestions from programmers and interface suggestions from users.

PS. FireMonkey is one of my 14 addons on AMO. My two recommended addons with combined 38+k users have not been subjected to git code publication requests.

atomGit commented 3 years ago

I use a plain editor l ...

which you can continue to do - git does not require any new software other than git which is free code and transparent to the developer except when you use it commit/push to the repo in which case it makes it a lot easier to do accurately and efficiently

Programmers, shouldn't have any problem extracting the XPI and inspecting the code

and comparing it to what? should every coder maintain their own git repo instead of you having 1 where they can easily read the commits?

lastly, i would not recommend github since it's now owned by fucking microsoft - instead there's gitlab, or better yet, codeberg

erosman commented 3 years ago

git does not require any new software

That means installing git, doesn't it? Therefore, I need to install additional software i.e. git, to accomplish this task. It also uses CLI which is not my forte.

comparing it to what?

Notepad++ can compare. There are other compare tools available. I do it all the time to compare a version to another.

... github since it's now owned by ... microsoft

:man_facepalming:

mainrs commented 3 years ago

That means installing git, doesn't it? Therefore, I need to install additional software i.e. git, to accomplish this task. It also uses CLI which is not my forte.

Please consider that ... Programmers, shouldn't have any problem extracting the XPI and inspecting the code [...].

That's true. You'd have to install git. However, it's super easy to install on Unix/Linux. sudo apt install git on Ubuntu for example. Given that you're not used to a terminal, you're probably using macOS or Windows. On macOS it's preinstalled and on Windows it's a simple installable: https://git-scm.com/downloads. There are also good (and open-source) GUI clients for git that make it really easy to get started alongside a good tutorial on the internet. I'll link them below if you're curious :)

Therefore, I need to install additional software i.e. [...].

Note that it's almost always a given that a developer (nowadays) has git installed. It's the goto tool for VCS.

I'm still glad that you took your time and read through the comment @erosman :)

GitHub Desktop: open-source https://desktop.github.com/ GitKraken: https://www.gitkraken.com/

erosman commented 3 years ago

I am on Windows. I will check those out.

rezad1393 commented 3 years ago

I am on Windows. I will check those out.

at the risk of not being related to topic, why are you on windows 7? is is hardware limits? as in, windows 10 doesnt install on you hardware? if so may I recommend linux? I tried linux 16 years ago and haven't looked back, and I am NOT a programmer just a user. unless you need windows for some specific application that has no linux alternative (maybe a engineering application) I highly (very highly) recommend linux.

also I think you get the vcs concept wrong. it is about tracking changes in a project. say you add some feature and remove others at a specific date. then later you want to re-add the removed features. the git (or any version control system) would allow you to do that and check for you if you need to change a lot of files or not. again: git is not just for collaboration between more than one person on a project. I am not a programmer but every starter programming guide that I saw in the last 10 years start with learning a version control system (usually git because it is foss ,created by linux creator, linus trovalds) . it actually helps starter and intermediate programmers more than the very professional ones because it shows your own history of changes and you can learn a lot from that.

I really really hope I got you wrong and you didnt mean that you just use a text editor with no vcs used.

a long time ago I decided that if there is a foss application that may even has less feature than the propriety ones that I would use the foss one. for example you own sample of apps for scripts: I used to have Tampermonkey installed because it was a good app. then they decided to remove the foss license and I remove it and replaced it with better open source ones (like the greasemonkey). the high number of installs is from the foss days of it.

you are right that they minified the code but they are still opensource licensed. which to me as a end user means that the bug reports and issues and feature request that I submit matter because if the developers decide that they dont want to fix those or disagree with me, but another developer agrees then that one can fork the project and not have to start from scratch. this is ( as I said in my older post) more than just a quirky personal thing. it is a philosophy.

of course you as a free human being can choose whatever meets your needs. but as a internet friend I highly recommend using at least a Version control system (git is good) and even better switch to linux to get rid of all the trash and ads and spying of windows.

erosman commented 3 years ago

at the risk of not being related to topic, why are you on windows 7? is is hardware limits? as in, windows 10 doesnt install on you hardware?

Win10 will be a bit heavy for my i5 with 4gb RAM :disappointed:

if so may I recommend linux? I tried linux 16 years ago and haven't looked back, and I am NOT a programmer just a user. unless you need windows for some specific application that has no linux alternative (maybe a engineering application) I highly (very highly) recommend linux.

TBH, I tried Linux (dual boot) 20+ years ago (Slackware, Gentoo, Debian) and it was not easy for me and the kernel panic got me frustrated.

However, I have been thinking about Linux for a few years now. I have been looking for a stable (no kernel panic) distro but everybody has a different opinion on the most suitable Linux for my use.

PS. I will reopen this topic for more feedback.

rezad1393 commented 3 years ago

Win10 will be a bit heavy for my i5 with 4gb RAM disappointed

if so may I recommend linux? I tried linux 16 years ago and haven't looked back, and I am NOT a programmer just a user. unless you need windows for some specific application that has no linux alternative (maybe a engineering application) I highly (very highly) recommend linux.

TBH, I tried Linux (dual boot) 20+ years ago (Slackware, Gentoo, Debian) and it was not easy for me and the kernel panic got me frustrated.

However, I have been thinking about Linux for a few years now. I have been looking for a stable (no kernel panic) distro but everybody has a different opinion on the most suitable Linux for my use.

PS. I will reopen this topic for more feedback.

windows 10.......... whenever I have to touch a computer with a windows 10 on it I shudder and disinfect my hands and take a shower. :)

I use archlinux but for a beginner it may be too much at first. about linux I recommend ubuntu for beginners and maybe fedora for intermediate.( two very different philosophies for their creators). ubuntu is tried and tested and the first linux distro that got massive adaptation (based on the great stable debian distro)

linux works good with low ram and it is (in my opinion) way more simple than windows to use and learn.

if you are a person that (based on your post history for editor choice) a kinda minimalist, then linux is THE undisputed king of that way.

if you tested linux 20 years ago , there is no comparison with linux today. so I say go for it and maybe later we can convert you to git too ;) based on your spec (4GB ram) then the laptop (or pc) is not a weird config so the chance that linux doesnt work great on it is very very low.

but if you want you can post you computer spec (or laptop model) and we can search for any linux incompatibility.

mainrs commented 3 years ago

Just chiming in on the Linux distros. Ubuntu and PopOS are really straightforward to install and have a very similar user interface to Windows IMO. I wouldn't touch Arch if it's your very first Linux experience in over 20 years. It's hard to install, needs a lot of maintainence.

https://pop.system76.com/ https://ubuntu.com/

erosman commented 3 years ago

Thank you for the suggestions. Best Linux Distributions That are Most Suitable for Beginners also has similar suggestions. TBH, I have to buy a new laptop, install Linux on it and gradually move to it from my current laptop. Do Linux distros handle hardware drivers automatically?

rezad1393 commented 3 years ago

Thank you for the suggestions. Best Linux Distributions That are Most Suitable for Beginners also has similar suggestions. TBH, I have to buy a new laptop, install Linux on it and gradually move to it from my current laptop. Do Linux distros handle hardware drivers automatically? in short mostly yes.

this is just my long opinion : if you want to buy a new laptop that does not need heavy A.I. activity usage or something else that mandates nvidia usage on linux, then absolutly go for amd gpu or (a little bit weaker one) intel gpu. I have a laptop from 10 years ago (yes it has beed that long but I upgraded the hdd to ssd and have 12 GB RAM) and it has intel cpu and gpu and nvidia for gpu as a dedicated card. in the whole times I tried to use nvidia with linux, be it via optimus config and any other way, it was mostly a headache at best. also my older pc got its gpu fried because nvidia released its updates manually and I forgot to update for a week and as my luck would have it I got the one driver with fan issue that fried the card.

also wayland (new display server on linux that is replacing x server) doesnt play nice at all with nvidia. all told, because nvidia is a binary proriotery driver you WILL get issues but with amd if you get issues you can also count in open source part to fix it, and with intel it is even better support (intel doesnt have non-opensource gpu driver on linux at all). so in my opinion basically avoid nvidia if you can.

other hardwares are usually supported unless it is something weird,niche or very very new. like rgb leds or some tablet/laptop combos. if the laptop you buy in not leading edge and very very new then you usually dont get errors or kernel panics in general.

if you want you can massage me with your desired laptop spec needs or a even better a specific laptop and I try to check it out on internet and sites that review them and give you back feedback before you commit to buy one.

erosman commented 3 years ago

if you want to buy a new laptop that does not need heavy A.I. activity usage or something else that mandates nvidia usage on linux, then absolutly go for amd gpu or (a little bit weaker one) intel gpu.

Most of the ones I looked at were with Nvidia Geforce.

Upgrading from my current Acer Aspire V3-571G, i5 4GB RAM, I would like something i7, 16GB RAM, 512 SDD (no HDD), Gen10 (prefer Gen 11) CPU.

I have had a few Acer laptops and have been generally happy with them. I also had Dell but never again. I am considering Acer or Lenovo :thinking:

rezad1393 commented 3 years ago

Most of the ones I looked at were with Nvidia Geforce.

I feel your pain. I have the same issue too that I need to get a new laptop (this one is showing its age) and I absolutely dont want nvidia because at best it would just be a redundant unused part of laptop. as I said, until nvidia open sources its driver I dont intend to buy from them.

but of course you can ignore that if you want but I would not recommend. btw there was a rumor that some big company graphic was gonna release open source news and there was a rumor that it may be nvidia but I wouldnt hold my breath. a big part of nvidia model is giving the source to just cooperation under NDA agreements.

there are new laptop (intel 11 gen) with good integrated (not dedicated) gpu that would satisfy me but I live in iran so I have to wait a bit for them to get to market here.

the one I saw some months past was this : https://www.notebookcheck.net/Lenovo-Yoga-Slim-7i-Carbon-13ITL5-laptop-review-Tiger-Lake-combined-with-ultralight-materials.530239.0.html#toc-verdict-the-lenovo-yoga-slim-7i-carbon-is-a-winner

btw this website is a good website that reviews laptops in house and in very detailed manner. https://www.notebookcheck.net/Reviews.55.0.html you can filter by manufacturer if you want too.

also I see some more intel laptop with integrated gpu releases so you still have a high chance to avoid nvidia if you want. specially if you dont need to for AAA gaming or something like that (which would be better server by desktop anyway. also what is your budget for the new laptop?

mainrs commented 3 years ago

You can still go NVidia if you don't care about opensource drivers. Their propriatary drivers are (as far as I remember) working fairly good. I got my 1070 working with them on Arch fairly easily. It's been some time though and maybe that landscape has changed as well :thinking:. Make sure to do your research though! :)

However, Linux community seems to prever AMD GPUs due to them having fully opensource drivers.

rezad1393 commented 3 years ago

You can still go NVidia if you don't care about opensource drivers. Their propriatary drivers are (as far as I remember) working fairly good. I got my 1070 working with them on Arch fairly easily. It's been some time though and maybe that landscape has changed as well thinking. Make sure to do your research though! :)

However, Linux community seems to prever AMD GPUs due to them having fully opensource drivers.

it is not just preferring, it is the less headache with amd and also even less headache with intel.

for example right now I use something called flatpak. which is a kinda like a container based app manager, as in every app is kept in a separate forlder and also have some privacy and security improvement over traditional system of installing apps in linux. (fedora silverblue is a distro that have literally replaced most of the traditional packages with flatpak packages.

now when I want to use steam in flatpak I have to somehow tell it to work with nvidia. but because nvidia on my laptop needs optimus to be run I have to use that which does not work with flatpak architecture. I think amd and intel would work with that because the files are there and flatpak developers can tweak it to detect the cards that are there. but nvidia propriety binary ones are not really tweakable so I am stuck with a steam with integrated and very old and weak intel gpu. so my nvidia is just sitting there doing nothing.

and this is just one small issue that I have with it. search wayland and nvidia and you will see scores of people that have issues with it.

but these are all just suggestions to avoid further issues and headache for a new linux user. I cant force him to avoid nvidia. I just share my experience with him. he wants to try linux again and I think linux without nvidia is way more pleasant experience.

erosman commented 3 years ago

I was also reading 4 Best Graphics Cards for Linux Users which states:

For this reason, many in the Linux community prefer to use AMD Radeon GPUs. Their drivers are open-source, included in the Linux kernel, and require no fiddling to get things working.

Lenovo Yoga is 13 inh. I would get a 15 inch laptop (I have been using 2 monitor for the last 25+ years, laptop + external).

I don't play games any more. I am not very worried about the budget and I was checking Lenovo Legion 5 but it uses Nvidia Geforce :thinking:

Actually, Lenovo ThinkPad E15 seems to use AMD Radeon RX.

rezad1393 commented 3 years ago

I was also reading 4 Best Graphics Cards for Linux Users which states:

these are desktop cards but the driver opensource still applies.

not to confuse you but this is an issue like this: https://old.reddit.com/r/linuxhardware/comments/go5eys/lenovo_thinkpad_e15_question/

but I think you are better served with a intel 11 gen instead of 10 gen.

erosman commented 3 years ago

AFA laptop support.... Now You Can Buy Linux Certified Lenovo ThinkPad and ThinkStation (For the Best Possible Out of the Box Linux Experience)

Lenovo Brings Linux® Certification to ThinkPad and ThinkStation Workstation Portfolio, Easing Deployment for Developers & Data Scientists

rezad1393 commented 3 years ago

this is old news but I didnt know you knew that much. yes lenovo has parthnered with redhat (owner of fedora) to basically create linux certified laptops. which is big news because the certification means backing and that allows companies it people to convince the higher ups to allow linux on devices of company.

for end users it mean no more checking to see if some driver works and if you driver later has issues then the fix the issue upstream (which mean in the linux kernel and not a separate hack that you have to manually install)

this is a (I think) more that 6 month old news and the good part is that they are gonna do it retroactively for some lines on lenovo. I think thinkpads.

but I didnt pry much to that even though it is a good thing, because thinkpads are too expensive for me relative to other laptops (like acer or asus or huawei). but they are a good choice for corporations. also most thinkpads are not thin and light (though that is not always true).

this is one if the news ones with review (i7 and gen 11) https://www.notebookcheck.net/Lenovo-ThinkBook-15-G2-ITL-i7-1165G7.534044.0.html but I dont wanna recommend something that later you regret so I dont point to one laptop but if you find 2 or 3 that you like I can check with my limited xp and see it there is glaring issues (like a model that doesnt support wifi)

erosman commented 3 years ago

If you have any suggestions for a high spec laptop suitable for Ubuntu installation, please let me know.

rezad1393 commented 3 years ago

If you have any suggestions for a high spec laptop suitable for Ubuntu installation, please let me know.

so ram 16 and higher cpu 11 gen intel or a good amd . but what about display size and weight and number of ports (do you need thunderbolt or not).

erosman commented 3 years ago

so ram 16 and higher cpu 11 gen intel or a good amd . but what about display size and weight and number of ports (do you need thunderbolt or not).

I don't have anything that uses thunderbolt. Since I always use a second monitor, a 14inch would also work but almost all 14" laptops are low specs. Therefore 15.6" would be best.

rezad1393 commented 3 years ago

and you are against dell right? and do you want and slim one or not important?

erosman commented 3 years ago

I haven had a good experience with Dell. I prefer lighter/slimmer ones if possible but specs are important.

rezad1393 commented 3 years ago

https://www.laptoparena.net/laptop-finder?Internal_memory=16-128_GB&Display_diagonal=15-21_inch&Total_storage_capacity=500-5120_GB&Brand=Acer,Lenovo&Processor_family=11th_gen_Intel_Core_i7&Discrete_graphics_adapter=N

rezad1393 commented 3 years ago

https://www.notebookcheck.net/Lenovo-ThinkPad-L15-laptop-review-Decent-office-companion-with-high-system-performance.503342.0.html

if you can wait some time,at most 3 months, then the new amd and intel cpus come and then the older ones (last year one) get more available. https://www.crn.com/slide-shows/components-peripherals/9-business-laptops-with-the-new-amd-ryzen-5000-cpus/3

rezad1393 commented 3 years ago

if you have a matrix username we can chat over there. this is not really suitable for laptop hunting.

erosman commented 3 years ago

Is Intel Iris Xe Graphics supported by Ubuntu?

I dont have matrix username.

rezad1393 commented 3 years ago

Is Intel Iris Xe Graphics supported by Ubuntu?

absolutely. As I said intel does have non-open source gpu for linux. so it is all open source. even more stable than amd.

I dont have matrix username.

it is a great network even mozilla replaced irc with matrix. https://wiki.mozilla.org/Matrix

erosman commented 3 years ago

I am on https://chat.mozilla.org/ (same username)

rezad1393 commented 3 years ago

chatted you there

afontenot commented 3 years ago

Hey @erosman I don't have time to read every comment in this thread so I don't know exactly where this stands, but I'm excited to see that there's a userscript manager that uses the userScripts API in Firefox - and even better one that is actively receiving new development time. Thanks for your work, I was actually thinking about creating one myself until I found this.

Greasemonkey on Firefox (283,000+ users) code is clear and on github but it is worked on by more than one person

I think this has the possibility of being a self-fulfilling prophecy. If there's a barrier to entry for contributions (on Github, sending your changes to be merged requires one click) then you can probably count on not receiving many contributions. Code that only ever gets uploaded to AMO feels like a private project, where contributions from others will not be welcomed, even if that's untrue.

If you're not comfortable using git or tracking every change doesn't fit well with your workflow, can I suggest the following approach as a stopgap measure? Create a repository with the code for Firemonkey (good name by the way), and only update it whenever you cut a new release on AMO. You can just stick every change in one commit for now. If you make this change, at least there will be code representing all the AMO releases on Github.

This would have the additional advantage of making it easier to find problems introduced by new releases.

Thanks for your time!

Iey4iej3 commented 3 years ago

Is Intel Iris Xe Graphics supported by Ubuntu?

I dont have matrix username.

There is another way to simplify these installations: you could look for laptops with Ubuntu pre-installed.

I don't play games any more.

You could look at laptops for business. For example, you could look at Dell Latitude series.

sealor commented 3 years ago

After reading all the comments I noticed that many comments already pointed out why it would be very useful to have the source code here on Github or any other code publishing platform. I also understood that using Github would hinder the workflow of the author.

So, we need an idea which fulfils both interests.

Does anybody know how Github actions work? Is it possible to regularly download, extract and commit the XPI into a git repository?

erosman commented 3 years ago

TBH, I have thought about uploading some (3-4) core files of FireMonkey so that they can be viewed.

There is no point in uploading everything e.g. CodeMirror, libs etc. However, that would have lead to loads of complaint from people who like to clone (fork) the code as their own repository, since those files alone wouldn't be enough to be packed into a compete add-on.

I have already seen many examples of people who fork, rename and release the identical code as their own (including FireMonkey that someone tried to release as ScriptMonkey). There have been tens of thousands of such instances on AMO (and they get removed by AMO).

I surmised that those who are programmers, know how to inspect the code from the XPI, and those who are not programmers wouldn't need/want to inspect the code anyway.

Iey4iej3 commented 3 years ago

I think it better to start with seeing whether versioning control tools like git help, which is completely local (nothing to upload). If it does help, then it might be worthwhile to "upload" to GitHub.

bb010g commented 3 years ago

if you'd be interested in using a GUI Git porcelain over a command-line porcelain, Sublime Merge is excellent.

The main reason I'd be interested in having version-tracked source easily readable online is for easily tracking how things have changed over time, without probably creating my own Git repository out of a bunch of extracted XPIs, and for being able to easily submit patches if I find a problem. (You wouldn't be obligated to accept the patches, but I personally like to try to fix a thing if it's broken and the source is available to me, to make maintainers' jobs a bit easier. If anything, it's a bit more documentation about my problem and what a partial fix might be.)

I'd also be willing to help you set up a historical Git repository, if that's something you'd be interested in.

erosman commented 3 years ago

As a trial ... I created a branch and release... Note: contains only main FM files

https://github.com/erosman/support/tree/FireMonkey

Iey4iej3 commented 2 years ago

As a trial ... I created a branch and release... Note: contains only main FM files

https://github.com/erosman/support/tree/FireMonkey

It seems that you "add files by upload", but it should be as simple as git commit -am "XXX" and git push. And seemingly, it should be a repo instead of a branch. Quote

Branching means you diverge from the main line of development and continue to do work without messing with that main line.

from this textbook.

erosman commented 2 years ago

I have uploaded the code as a trial, for discussion only. It is not a source code for reproduction. I do NOT develop on Github and I often make 100s of changes in a single day. It is not feasible for me to to reflect them here. I do not use command line and I am currently on windows. This repo is SUPPORT for all my addons. FireMonkey is a branch of that support.

pintassilgo commented 2 years ago

If it's useful to someone:

diff v2.37

diff v2.36

diff v2.35

...

bb010g commented 2 years ago

@erosman Thank you! Adding files by upload on each release is fine, if that works for you.

It seems that you "add files by upload", but it should be as simple as git commit -am "XXX" and git push. And seemingly, it should be a repo instead of a branch.

@Iey4iej3 A branch works fine. Git itself doesn't really care. You can have completely unrelated branches in the same repository; this is how GitHub Pages branches like to work.

erosman / support

Firemonkey: source code #234