search

erosman / support

Support Location for all my extensions
Mozilla Public License 2.0
172 stars 12 forks source link

[FireMonkey] unsafeWindow stopped working #262

Closed kekkc closed 3 years ago

kekkc commented 3 years ago

Hi Erosman,

since a few versions, I realized that unsafeWindow no longer works ("without error messages").

As a workaround I replaced let confirm = new window.Function('return true'); unsafeWindow.confirm = confirm; with let confirm = new window.Function('return true'); window.wrappedJSObject.confirm = confirm;

Which is still working. Do you know if this is related to FF changes (I initially preferred unsafeWindow because of script "compatibility with other script managers)?

erosman commented 3 years ago

You are right. Sorry... that is due to changes in v1.45 which broke unsafeWindow (made it one way). I fixed it now and will be in v2.0 (with a whole lot of other things).

I will release v2.0 very soon if you can wait a little bit.

erosman commented 3 years ago

v2.0 released... fingers crossed ;)

kekkc commented 3 years ago

As usual, a "little bit" was blazingly fast. Many thanks for the super fast fix ;)