search

erosman / support

Support Location for all my extensions
Mozilla Public License 2.0
168 stars 12 forks source link

[FoxyTab]Take hash property into consider when closing duplicated tabs. #550

Open RealXuChe opened 1 year ago

RealXuChe commented 1 year ago

Some sites will display different pages based on different hash properties. Netease music is an example of this, you can try to open https://music.163.com/#/song?id=28718934 and https://music.163.com/#/song?id=1327255396, and you will be presented with different pages. However, since the URLs before the hash property are same, when deduping with FoxyTab, these tabs will be considered identical. Only one tab will be retained.

I suggest that you can have a whitelist for sites that have such behaviour, and for such sites, dedup using the full URL.

erosman commented 1 year ago

Previously: #191 , #330, #490

RealXuChe commented 1 year ago

I have read through other duplicate issues. Thanks you for putting in the effort on this issue!

Providing a setting to include anchor in determining if two URLs are different, might break the plugin's behavior on standard-compliant pages. For those non-compliant websites, I think the best solution is to allow users to provide a whitelist, or ship with a community-maintained whitelist. And only evaluate the anchor for websites in the whitelist. This way, users will be able to choose the behavior they want to use, and won't break the plugin's behavior on standard-compliant pages. Thank you!

erosman commented 1 year ago

I will see what can be done when working on the next update of FoxyTab.