search

erosman / support

Support Location for all my extensions
Mozilla Public License 2.0
172 stars 12 forks source link

[FireMonkey] 4chan-XT compatibility #590

Open ghost opened 1 year ago

ghost commented 1 year ago

I have used the 4chan-X userscript for quite a while with FireMonkey. I do recall it originally had some issues1, 2, 3 that have since been worked out. There is currently a more active and modern rewrite in development meant to migrate from CoffeeScript to TypeScript called 4chan-XT. There is a relevant issue where the problem is explained, but the dev does not seem to want to work on compatibility with FireMonkey himself.

I'm not an expert in JavaScript, but I'm just curious: what would be needed to get this script to work with FireMonkey? Once I manually click "run" it works perfectly.

I do understand this is not entirely a FireMonkey problem. Thanks for any response.

erosman commented 1 year ago

re: 4chan-XT-noupdate.user.js

Manifest V3

Changes in User scripts in Manifest V3, should make all userscript managers more uniform as far as context is concerned.

Currently, @include is not supported in MV3 and points mentioned in #408 are also noteworthy.

Run vs Auto-run

If the code runs correctly via manual "Run", then the issue relates to the context i.e. content vs userScripts context.

What is Violentmonkey injection mode set to?

image

ghost commented 1 year ago

I'm not sure I understand, I don't use Violentmonkey.

erosman commented 1 year ago

I'm not sure I understand, I don't use Violentmonkey.

Oh, sorry. I thought you had tested the userscript in other userscript managers.

There is currently a more active and modern rewrite in development ...

Unfortunately, the code is too large for me to debug. If I know the issue, I might be able to work something out and/or make a suggestion.

ghost commented 1 year ago

Unfortunate. I wouldn't have any idea what needs to be changed. Thanks anyway