search

erosman / support

Support Location for all my extensions
Mozilla Public License 2.0
174 stars 12 forks source link

Slight reduction in size #621

Closed 0x21D8 closed 11 months ago

0x21D8 commented 11 months ago

All compression algorithms are lossless except for alpha channel, in alpha channel all colour values of fully transparent pixels have been changed, which is technically lossy but impossible to notice except in some rare cases. Please let me know if the alpha channel modification is inappropriate and I'll change it.

erosman commented 11 months ago

TBH, the reduction is size in insignificant. Furthermore, these images do not belong to me so I thought it would be better to keep them untouched.

0x21D8 commented 11 months ago

TBH, the reduction is size in insignificant. Furthermore, these images do not belong to me so I thought it would be better to keep them untouched.

It's insignificant because of the original size of the images AND because it's lossless compression. Lossless compression should be legal. It doesn't change anything about the logo itself, and the alpha channel is just a colour space, it's a simple shape, or one that's commonly used, so it can't be copyrighted on its own. If you don't really understand how the lossless compression algorithm works.

0x21D8 commented 11 months ago

It would be really nice if you would think about merging this, not because of the "insignificance", (personally, and I hope not only for me, I find this significant enough) but because of the principle of minimalism, since it is intended as "Super Lightweight". and every free bit is actually nice to have. Later I will try to do something with svg and there will be much more saving, so in optimisation you have to start with something, starting from the simplest and most primitive things to the most complex, and if you really care, then I don't even need to explain other reasons.

erosman commented 11 months ago

If they could be made into SVG, that would be great.