search

erossini / BlazorChartjs

Creates beautiful charts in Blazor using Chart.js. Library for NET6, NET7 and NET8. Source code and demo available.
https://www.puresourcecode.com/dotnet/blazor/blazor-component-for-chartjs/
MIT License
120 stars 44 forks source link

Implementation of beginAtZero, min & max properties for radar charts #73 #76

Closed sikelio closed 4 months ago

sikelio commented 5 months ago

Hi again i was waiting for the update in .NET 8, so here comes back my contributions to radar charts

Implemented the following properties for radar charts :

erossini commented 5 months ago

Thank you so much for your PR Enrico

sikelio commented 4 months ago

Hello again, while waiting the update, I've imported the fork I've made into my project and I found these lines show was duplicated. So I removed them :) .

erossini commented 4 months ago

Haven't I updated the project? 😮

sikelio commented 4 months ago

Don't worry, you have updated the project to .NET 8 ^^ I was just refering to the initial goal of this PR :)

sikelio commented 4 months ago

Oupsi, I don't understand why there is a conflict :/ It seems you've added my PR before me x)

(sorry for my bad english)

erossini commented 4 months ago

Yesterday I reorganized my code and made some changes in the past. I saw your PR and I added in my project some of your changes in particular for Radar to avoid errors. I think the conflicts are coming from the changes I have already made.

Sorry for the confusion. Enrico

sikelio commented 4 months ago

No problem :) So I can close the PR ?

erossini commented 4 months ago

Yes, thank you