erpc-io / eRPC

Efficient RPCs for datacenter networks
Other
851 stars 138 forks source link

Improve exception safety with smart pointers #24

Closed elfring closed 5 years ago

elfring commented 5 years ago

Would you like to wrap any pointer data members with the class template “std::unique_ptr”?

Update candidates:

anujkaliaiitd commented 5 years ago

Thank you for the suggestion. I don't currently understand smart pointers, but I hope to use them in the future.

The Rpc class cannot be a unique_ptr because it may be shared with eRPC's background threads.

anujkaliaiitd commented 5 years ago

This is probably outside the current scope of the project.

elfring commented 5 years ago

Why?