errandwolfe / growl

Automatically exported from code.google.com/p/growl
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Improve layout of "Clear All History" button #598

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
This is just a very tiny and simple suggestion.

What steps will reproduce the problem?
1. Open the History pref pane
2. See "Clear All History" very squeezed in its surrounding box

Please provide any additional information below.
Apple standard usually avoid have words so close to the the borders, and it's 
true it's not beautiful.
Even the similar boxes, "+" and "-", in this pane and Network pane have larger 
margins.

Maybe a simple solution would be to automatically surround this particular text 
with spaces " Clear All History " so as to increase the visual margins.

Original issue reported on code.google.com by yann.ric...@gmail.com on 24 Jun 2013 at 3:40

GoogleCodeExporter commented 8 years ago
So, in actuality, our buttons on the networking tab are the ones that are in 
the wrong here size wise.  Apple's default height for a gradient button is 23 
pixels, however, the networking tab ones are in fact, 24, while the history tab 
is the proper height.  The networking tab required a fixed height be set 
because autolayout was being stubborn, and my brain wasn't thinking about what 
its standard really was and rounded the number to an even 24, while the history 
tab has a button height determined by the system.

There are problems however with our usage of "Clear all History" in a gradient 
button though.  From the HIG:
Gradient buttons contain images; they do not contain text
So thats wrong.  However, there is no good standard icon for "Delete all" that 
I know of.  Im not closing this, but Im flagging as in discussion, setting a 
low priority, and setting its milestone to later.

Original comment by dan...@growl.info on 25 Jun 2013 at 4:29