Notification-Center forwarding fails with non Growl.framework GNTP implementation

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Find a non Growl GNTP implementation which doesn't send Origin-Software-Name 
and Origin-Software-Version
2. Switch on global NC forwarding (or use a rule for that note)
3. Send notification from the local machine

What is the expected output?
The note goes to NC

What do you see instead?
The note silently fails to go to NC

The failing is in the following function
-(BOOL)sendNotificationDict:(NSDictionary*)growlNotificationDict
                  feedbackOfType:(NSString*)feedbacktype
We message a potentially nil object, comparing it to @"Growl.framework", since 
messaging nil returns 0/NO/nil, we get a response back that possibly matches 
our NSOrderedSame check, resulting in it falling through to the next check.   
We check whether it was sent locally, that passes, and then we compare versions 
with 3.0, this time our check passes because compareVersionStrings(@"3.0", 
<note sender version>) will return a non kCFCompareGreaterThan value with a nil 
<note sender version>

This should be an easy enough fix, check if our strings are nil before 
comparing them.  Simply making this ticket so we remember to do it.

Original issue reported on code.google.com by dan...@growl.info on 2 Nov 2013 at 2:43

[GoogleCodeExporter]

Issue 622 has been merged into this issue.

Original comment by dan...@growl.info on 3 Nov 2013 at 3:18

[GoogleCodeExporter]

Closing as fixed in source as of [e3192732d1fd286d51628c51856b386b8edf6bc9] on 
Default

Original comment by dan...@growl.info on 25 Mar 2014 at 3:17

• Changed state: FixedInSource