AMPM matches non-time text

errata-ai / Google

A Vale-compatible implementation of the Google Developer Documentation Style Guide.

MIT License

69 stars 23 forks source link

AMPM matches non-time text #37

Closed datawookie closed 6 days ago

datawookie commented 1 week ago

Hi!

I've been using these rules and they have greatly improved my text. However, I came across something unexpected. The AMPM rule is being activated by text like "5 ampoules". Looking at the rule I can see that this text would match the last REGEX, '\d{1,2} ?[aApP]\.[mM]\.'.

Is this the expected behaviour?

Best regards, Andrew.

jdkato commented 6 days ago

This should be fixed in the next release.

datawookie commented 6 days ago

Brilliant. Thanks for sorting so quickly!