Normalize first person and first-person plural

errata-ai / Microsoft

A Vale-compatible implementation of the Microsoft Writing Style Guide.

https://github.com/errata-ai/vale

MIT License

85 stars 46 forks source link

Normalize first person and first-person plural #23

Closed markekraus closed 5 years ago

markekraus commented 5 years ago

Moves First-Person Plural to the We rule
Normalizes tokens on word boundaries
Updates tokens for both to be more exhaustive

markekraus commented 5 years ago

woops.. forgot tests.. will update soon

markekraus commented 5 years ago

Ok.. should be good to go now. I see why you have the weird rule for I. added an I, rule as we had several chapters where that was being missed. I could not come up with a good regex to capture both.

jdkato commented 5 years ago

Thanks -- it looks good. Using We.yml is definitely the way to go.