search

errata-ai / Microsoft

A Vale-compatible implementation of the Microsoft Writing Style Guide.
https://github.com/errata-ai/vale
MIT License
85 stars 46 forks source link

"all of" rules are "inconsistent" in Vale 2.29.3 #57

Closed alexpdp7 closed 9 months ago

alexpdp7 commented 1 year ago

(I've seen no indication in 2.29.4+ that this problem is solved.)

https://github.com/errata-ai/Microsoft/blob/master/Microsoft/Wordiness.yml#L16

rules all of * collide with the all of rule, and for some reason, in my tests, this means that behavior is not consistent; sometimes one rule matches, sometimes another. This makes some kinds of reports we run for analysis a bit more difficult to perform.

alexpdp7 commented 1 year ago

We have addressed this with:

diff --git a/Microsoft/Wordiness.yml b/Microsoft/Wordiness.yml
index 2861eec..c157140 100644
--- a/Microsoft/Wordiness.yml
+++ b/Microsoft/Wordiness.yml
@@ -17,7 +17,7 @@ swap:
   all across: across
   all of a sudden: suddenly
   all of these: these
-  all of: all
+  all of (?!a sudden|these): all
   all-time record: record
   almost all: most
   almost never: seldom