Action never failed even if error level issues are detected & fail_on_error is set to true

errata-ai / vale-action

:octocat: The official GitHub Action for Vale -- install, manage, and run Vale with ease.

MIT License

201 stars 51 forks source link

Action never failed even if error level issues are detected & fail_on_error is set to true #103

Open fharper opened 1 year ago

fharper commented 1 year ago

I have the level set to error for my custom vocab, and substitution. When running the GitHub Action, vale report the issues with the proper error level. I also have fail_on_error set to true. No matter these, the action always succeed, and never fail. Here's the .vale.ini for reference.

I assume I either miss something, didn't use the argument properly or it's a bug. Any idea what is happening here?

karl-johan-grahn commented 1 year ago

@jdkato any idea?

fharper commented 1 year ago

Seems like it may be a reviewdog issue, and not vale since it's a reviewdog option.

If I'm not wrong, you can close this issue. I posted my workaround in the reviewdog issue https://github.com/reviewdog/reviewdog/issues/1408